Implement swift support and testing#395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 73.68% 74.26% +0.57%
==========================================
Files 11 12 +1
Lines 1463 1562 +99
==========================================
+ Hits 1078 1160 +82
- Misses 385 402 +17
Continue to review full report at Codecov.
|
dpogue
left a comment
dpogue
left a comment
There was a problem hiding this comment.
This all looks good to me, but I'll let someone with more iOS experience give it a more thorough review
| this.path = bridgingHeaderPath; | ||
| this.bridgingHeaders = null; | ||
| if (!fs.existsSync(this.path)) { | ||
| throw new CordovaError('BridgingHeader.js is not found.'); |
There was a problem hiding this comment.
This is actually if the BridgingHeader.h file is not found? The error message says .js
There was a problem hiding this comment.
I am aiming to check the BridgingHeader.h file exists or not.
Sorry I am going to fix the wrong message. Thank you a lot!
bin/templates/scripts/cordova/Api.js
Outdated
| bridgingHeaderFile.write(); | ||
| } | ||
| } | ||
| return Q.resolve(); |
There was a problem hiding this comment.
Do we need to return Q.resolve() here? I think if the function finishes with no exceptions, it should continue into the next .then block
There was a problem hiding this comment.
Thank you. There is no reason for Q.resolve(). I will remove it.
bin/templates/scripts/cordova/Api.js
Outdated
| bridgingHeaderFile.write(); | ||
| } | ||
| } | ||
| return Q.resolve(); |
There was a problem hiding this comment.
Again, I don't think we need to explicitly return Q.resolve() here
There was a problem hiding this comment.
Thank you. There is no paticular reason for Q.resolve(). I will remove it.
|
Thanks you! |
4 participants
Platforms affected
ios
What does this PR do?
Add swift support for ios platform and unit testing.
apache/cordova-discuss#107
This PR is needed to be merged first
apache/cordova-common#42 .
What testing has been done on this change?
Run 'cordova build' with this code and cordova-common change.
Run the jasmine tests.
Checklist