Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cocoapods support improvement, using podspec tag in plugin.xml #405
What does this PR do?
The following PR is needed to be merged first
What testing has been done on this change?
Because this PR depends on PR (apache/cordova-common#48), the test fails without editing package.json.
Thanks @knight9999 but the builds are failing:
Thanks! This can be reviewed and tested, but can't be accepted to be merged until the production release of cordova-common that has the changes needed is out for final testing.
We've had this situation before, and we just had to wait until the dependency is updated in npm. Thus, let us try to get cordova-common that has these dependent changes out for a new release, then we update this PR.
Apache Cordova: Platform Pull Requests
moved this from 🐣 New PR / Untriaged
to 🙅 Pending Approval
Sep 13, 2018
Sep 25, 2018
@@ Coverage Diff @@ ## master #405 +/- ## ========================================== + Coverage 74.29% 75.36% +1.06% ========================================== Files 12 12 Lines 1564 1802 +238 ========================================== + Hits 1162 1358 +196 - Misses 402 444 +42
erisu left a comment •
Ran following tests:
I also tested with the fake plugin that uses the new podspec pattern. This was only to validate that the new pattern added the Pods properly and built. Was not intended to test the running of the app with this fake plugin.