Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CordovaLib.xcodeproj file upgraded for Xcode 10 #489

Merged
merged 3 commits into from Jan 30, 2019

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jan 8, 2019

Platforms affected

iOS

What does this PR do?

Upgrades CordovaLib.xcodeproj to Xcode 10 standards

What testing has been done on this change?

All the objc unit tests pass locally with Xcode 10.1, opening this PR to see how they are handled by Xcode 9.

@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ef0cd...c902f2f. Read the comment docs.

@shazron
Copy link
Member

shazron commented Jan 9, 2019

Looks like the TravisCI tests all pass with Xcode 9. However, we don't seem to have Xcode 10 TravisCI tests in the matrix

@dpogue dpogue changed the title WIP: CordovaLib.xcodeproj upgraded for Xcode 10 WIP: xcodeproj files upgraded for Xcode 10 Jan 11, 2019
@dpogue dpogue changed the title WIP: xcodeproj files upgraded for Xcode 10 WIP: CordovaLib.xcodeproj file upgraded for Xcode 10 Jan 30, 2019
@dpogue dpogue changed the title WIP: CordovaLib.xcodeproj file upgraded for Xcode 10 CordovaLib.xcodeproj file upgraded for Xcode 10 Jan 30, 2019
@dpogue
Copy link
Member Author

dpogue commented Jan 30, 2019

@shazron I've reduced this back to just the CordovaLib.xcodeproj and CordovaLib deprecation changes, and added Xcode 10.1 to the CI matrix on Travis (while keeping a single run of Xcode 9.3 as a backward-compatibility check, pending further discussion)

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 11b136c into apache:master Jan 30, 2019
@dpogue dpogue deleted the X10CordovaLib branch March 6, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants