Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-498: (ios) support old cordova-common in which no getPodSpecs function #501

Merged
merged 1 commit into from Jan 20, 2019

Conversation

knight9999
Copy link
Contributor

@knight9999 knight9999 commented Jan 19, 2019

Platforms affected

Cordova-iOS

What does this PR do?

Fix the issue #498 .
The old cordova-common (2.x.x) has no getPodSpecs function.
To support the old cordova-common, skipping call getPosSpecs function if it does not exist.

What testing has been done on this change?

as follows on local my mac.
creating project by cordova 8.1.2 (cordova-lib@8.1.1, cordova-common@2.2.5).
adding this cordova-ios platform.
checking there is no errors.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #501 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4562ef5...c793e07. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpogue dpogue merged commit 31ef0cd into apache:master Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants