breaking(npm): bump dependencies (#225)

* breaking(npm): bump dev dependencies

- @cordova/eslint-config@^3.0.0
- cordova-android@^8.1.0
- cordova-ios@^5.1.1
- eslint-plugin-es5@^1.5.0
- grunt@^1.1.0
- jasmine-core@^3.5.0
- karma@^4.4.1
- karma-chrome-launcher@^3.1.0
- karma-coverage@^2.0.1
- karma-jasmine@^3.1.1
- puppeteer@^2.1.1

* breaking(npm): bump dependencies w/ fix

- execa@^4.0.0
- fs-extra@^9.0.0
- globby@^11.0.0

* chore(npm): rebuild package-lock
* chore: fix istanbul-lib-instrument usage
* chore(npm): lock karma-coverage to commit-id
* chore: fixup comment and formatting for istanbul-lib-instrument
* chore(npm): add coverage dir to ignore list
* chore(npm): revert karma-coverage back to release version

Co-authored-by: Tim Brust <tim.brust@sinnerschrader.com>
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>

.npmignore

@@ -1,4 +1,5 @@
 .*
 appveyor.yml
+coverage
 pkg
 test

build-tools/build.js

@@ -38,5 +38,5 @@ module.exports = function build (userConfig) {
 };
 
 function getCommitId () {
-    return execa.stdout('git', ['rev-parse', 'HEAD'], { cwd: pkgRoot });
+    return execa('git', ['rev-parse', 'HEAD'], { cwd: pkgRoot }).then(data => data.stdout);
 }

build-tools/test-build.js

@@ -4,8 +4,8 @@ const fs = require('fs-extra');
 const path = require('path');
 const { build, collectModules } = require('.');
 
-// Istanbul is provided by karma-coverage
-const { Instrumenter } = require('istanbul');
+// istanbul-lib-instrument is provided by karma-coverage
+const { createInstrumenter } = require('istanbul-lib-instrument');
 
 if (require.main === module) {
     buildCordovaJsTestBundle(process.argv[2])
@@ -19,7 +19,7 @@ module.exports = buildCordovaJsTestBundle;
 
 // Writes the cordova-js test build bundle to bundlePath
 function buildCordovaJsTestBundle (bundlePath) {
-    const instrumenter = new Instrumenter();
+    const instrumenter = createInstrumenter();
 
     return build({
         platformName: 'test',