Skip to content
Permalink
Browse files
Improve callback error handling (#211)
- Add `error` parameter to the `cordovacallbackerror` event so that users can access the original error.
    - This is extremely important so that users can get the stack trace for logging and debugging.
- Removed default logging of the error with `console.log`.
    - They were redundant since the error is printed to console when it is thrown anyway (if not caught).
    - console.log's without an option to turn them off can be annoying.
  • Loading branch information
Lindsay-Needs-Sleep authored and raphinesse committed Oct 25, 2019
1 parent c8aca1e commit 7d4d671c98d4cdafbe157795f6adad723adf9c13
Showing 2 changed files with 44 additions and 3 deletions.
@@ -234,9 +234,7 @@ var cordova = {
}
} catch (err) {
var msg = 'Error in ' + (isSuccess ? 'Success' : 'Error') + ' callbackId: ' + callbackId + ' : ' + err;
console && console.log && console.log(msg);
console && console.log && err.stack && console.log(err.stack);
cordova.fireWindowEvent('cordovacallbackerror', { 'message': msg });
cordova.fireWindowEvent('cordovacallbackerror', { 'message': msg, 'error': err });
throw err;
}
},
@@ -0,0 +1,43 @@
/*
*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
*/

describe('cordova', function () {
describe('callbackFromNative', function () {
it('Test#001 : should fire the cordovacallbackerror event if the callback throws', function () {
var id = 'myID';
var testError = new Error('errorMessage');
cordova.callbacks[id] = {
success: function () { throw testError; }
};

spyOn(cordova, 'fireWindowEvent');

expect(function () {
cordova.callbackFromNative(id, true, cordova.callbackStatus.OK, null, false);
}).toThrow(testError);

expect(cordova.fireWindowEvent).toHaveBeenCalledWith('cordovacallbackerror', {
message: jasmine.stringMatching('Error in Success callbackId: ' + id),
error: testError
});
});
});
});

0 comments on commit 7d4d671

Please sign in to comment.