Skip to content
Permalink
Browse files
Integrate unused CommonJS tests where applicable (#195)
There has been an unused copy of [The Official Specs for CommonJS][1]
lying around in our repository for who knows how long. They needed to be
built using a python script and then manually executed in a browser.
This commit integrates all of those tests that also apply to our module
system into our existing test suite for `require` & `define`.

Adds adapted versions of the following CommonJs tests to our
`test.require.js`:

    absolute, transitive, determinism, method, nested, hasOwnProperty

The hasOwnProperty test actually uncovered a bug in our module system
implementation and thus is deactivated right now.

The following CommonJS tests were not applicable to Cordova's module
system since it does not support cyclic dependencies at all:

    cyclic, monkeys

The following CommonJS tests were already covered by tests in
`test.require.js`:

- missing: covered by Test#005
- relative: covered by Test#012
- exactExports: covered by multiple tests

[1]: https://github.com/commonjs/commonjs
  • Loading branch information
raphinesse committed Apr 28, 2019
1 parent a61952f commit dd8b78f934e32994e3f8160c477064d801e8d1e3
Showing 49 changed files with 86 additions and 682 deletions.
@@ -1,2 +1 @@
pkg/**
tasks/vendor
@@ -1,3 +1 @@
tasks/vendor
vendor
appveyor.yml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit dd8b78f

Please sign in to comment.