Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron Support #188

merged 1 commit into from Feb 22, 2019

Add Electron Support #188

merged 1 commit into from Feb 22, 2019


Copy link

@erisu erisu commented Feb 22, 2019

Platforms affected


Motivation and Context

Add Support to Build for Electron


  • Added Electron path to package.json
  • Added Electron compile to Gruntfile.js


  • npm t


  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue Feb 22, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Feb 22, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Feb 22, 2019
Copy link

@knight9999 knight9999 left a comment

This is necessary update.

@erisu erisu merged commit 2d56086 into apache:master Feb 22, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Feb 22, 2019
@erisu erisu deleted the electron-support branch Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release

Successfully merging this pull request may close these issues.

None yet

2 participants