Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of some parameter formats in argscheck.checkArgs #200

Merged
merged 1 commit into from May 2, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented May 2, 2019

Motivation and Context

Some parameter formats were not parsed correctly in argscheck.checkArgs. This would lead to faulty error messages.

Description

Tweaked the RegExes in extractParamName to consume all white space around the tokens of interest.

The recognition is still not perfect (e.g. parameters with defaults). For that, one would have to employ an actual parser. But that's a bit over the top here.

Testing

Added regression test

@raphinesse raphinesse added the bug label May 2, 2019
@raphinesse raphinesse requested review from dpogue and erisu May 2, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests May 2, 2019
dpogue
dpogue approved these changes May 2, 2019
Copy link
Member

@dpogue dpogue left a comment

👍

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge May 2, 2019
@raphinesse raphinesse merged commit f0dfd36 into apache:master May 2, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release May 2, 2019
@raphinesse raphinesse deleted the fix-argscheck branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants