Skip to content
Permalink
Browse files
GH-676 Remove browserify (#682)
Resolves #676
  • Loading branch information
raphinesse committed Sep 6, 2018
1 parent fdf7dc5 commit 2ada2cebaa572ad363b16381bf64fe7d783c146d
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 201 deletions.
@@ -17,11 +17,9 @@
"node": ">=6.0.0"
},
"dependencies": {
"aliasify": "^2.1.0",
"cordova-common": "^2.2.0",
"cordova-create": "^1.1.0",
"cordova-fetch": "^1.3.0",
"cordova-js": "^4.2.2",
"cordova-serve": "^2.0.0",
"dep-graph": "1.1.0",
"detect-indent": "^5.0.0",
@@ -31,7 +29,6 @@
"indent-string": "^3.2.0",
"init-package-json": "^1.2.0",
"nopt": "4.0.1",
"opener": "^1.4.3",
"properties-parser": "0.3.1",
"q": "^1.5.1",
"read-chunk": "^3.0.0",
@@ -170,9 +170,6 @@ describe('cordova/prepare', function () {
expect(platform_api_prepare_mock).toHaveBeenCalled();
});
});
// TODO: xit'ed the one below as dynamic requires make it difficult to spy on
// Can we refactor the relevant code to make it testable?
xit('should invoke browserify if the browserify option is provided');
it('should handle config changes by invoking add_config_changes and save_all', function () {
return prepare.preparePlatforms(['android'], project_dir, {}).then(function () {
expect(platform_munger_mock.prototype.add_config_changes).toHaveBeenCalled();
@@ -109,7 +109,6 @@ function add (projectRoot, hooksRunner, opts) {
var platformRoot = path.join(projectRoot, 'platforms', platform);
var options = {
cli_variables: opts.cli_variables || {},
browserify: opts.browserify || false,
save: opts.save,
searchpath: searchPath,
noregistry: opts.noregistry,
@@ -103,13 +103,6 @@ function preparePlatforms (platformList, projectRoot, options) {
// config changes is not being reinstalled on each prepare.
var platformApi = platforms.getPlatformApi(platform);
return platformApi.prepare(project, _.clone(options))
.then(function () {
if (options.browserify) {
// TODO: dynamic require here makes it difficult to test this code branch.
var browserify = require('../plugman/browserify');
return browserify(project, platformApi);
}
})
.then(function () {
// Handle edit-config in config.xml
var platformRoot = path.join(projectRoot, 'platforms', platform);

This file was deleted.

@@ -30,7 +30,6 @@ var plugman = {
install: require('./install'),
uninstall: require('./uninstall'),
fetch: require('./fetch'),
browserify: require('./browserify'),
help: require('./help'),
create: require('./create'),
platform: require('./platform_operation'),
@@ -51,9 +50,6 @@ plugman.commands = {
if (!cli_opts.platform || !cli_opts.project || !cli_opts.plugin) {
return console.log(plugman.help());
}
if (cli_opts.browserify === true) {
plugman.prepare = require('./prepare-browserify');
}
var cli_variables = {};

if (cli_opts.variable) {
@@ -88,10 +84,6 @@ plugman.commands = {
return console.log(plugman.help());
}

if (cli_opts.browserify === true) {
plugman.prepare = require('./prepare-browserify');
}

var p = Q();
cli_opts.plugin.forEach(function (pluginSrc) {
var opts = {

0 comments on commit 2ada2ce

Please sign in to comment.