Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-8123 Plugin references can target specific windows platforms. #164

Closed
wants to merge 3 commits into from

Conversation

@TimBarham
Copy link
Member

@TimBarham TimBarham commented Feb 11, 2015

Adds support for target, versions and arch attributes on <lib-file> and <framework> elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms.

Also adds support for src attribute as an alias for the Include attribute on the <lib-file> element (since src is documented, but Include is used by existing plugins).

Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform).

As part of this change, refactored jsproj to jsprojManager to reflect the fact that, with the windows platform, this class now manages multiple jsproj files.

Broken into three commits to separate file renames from changes, so that git can successfully track the changes.

TimBarham added 3 commits Feb 11, 2015
Adds support for `target`, `versions` and `arch` attributes on `<lib-file>` and `<framework>` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms.

Also adds support for `src` attribute as an alias for the `Include` attribute on the `
<lib-file>` element (since `src` is documented, but `Include` is used by existing plugins).

Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform).

As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files.

I will rename some windows8 files and folders to windows, and jsproj.js to jsprojManager.js in a subsequent commit.
Renames `windows8` plugin platform folders in tests to `windows`. Renames `jsproj.js` to `jsprojManager.js`.
Renames `windows8.spec.js` to `windows.spec.js`.
@sgrebnov
Copy link
Member

@sgrebnov sgrebnov commented Feb 11, 2015

Reviewed and tested, LGTM 👍

@purplecabbage
Copy link
Contributor

@purplecabbage purplecabbage commented Feb 12, 2015

Thanks Tim! This is now merged, the mirror is just slow to update. This should close in a few minutes.

@TimBarham
Copy link
Member Author

@TimBarham TimBarham commented Feb 12, 2015

Thanks Jesse!

@stefangordon
Copy link

@stefangordon stefangordon commented Feb 12, 2015

Great stuff! Any pointers on how users can easily install this via NPM now? I've only had success manually cloning the lib and cli repos and copying correct binaries.

@TimBarham TimBarham closed this Feb 18, 2015
@TimBarham TimBarham deleted the MSOpenTech:CB-8123 branch Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.