Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11713 and CB-11961 #563

Closed
wants to merge 2 commits into from
Closed

CB-11713 and CB-11961 #563

wants to merge 2 commits into from

Conversation

goya
Copy link
Member

@goya goya commented Jun 14, 2017

Platforms affected

N/A

What does this PR do?

Fixes for the following issues:

CB-11961 do a shallow clone if git_ref is a remote ref
CB-11713 no CLI feedback on plugin version installed during plugin install

What testing has been done on this change?

jasmine tests

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@goya goya changed the title Cb 11713 11961 CB-11713 and CB-11961 Jun 14, 2017
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #563 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   80.12%   80.17%   +0.04%     
==========================================
  Files          57       57              
  Lines        3960     3969       +9     
  Branches      832      832              
==========================================
+ Hits         3173     3182       +9     
  Misses        787      787
Impacted Files Coverage Δ
src/gitclone.js 100% <100%> (ø) ⬆️
src/plugman/install.js 84.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69b9e4...1c820da. Read the comment docs.

@goya
Copy link
Member Author

goya commented Jun 15, 2017

should be fixed now. got bit by false git documentation on git < 2

@goya
Copy link
Member Author

goya commented Jun 17, 2017

oh well ill just leave this here until master gets working tests again.

@filmaj
Copy link
Contributor

filmaj commented Jun 17, 2017

Thanks for waiting @goya ! @stevengill, @audreyso and I are working on that.

@filmaj
Copy link
Contributor

filmaj commented Jun 22, 2017

@goya CI should be passing now, you'll need to rebase as a bunch of files moved around as part of the plugin command refactor and test speed improvements we landed.

The spec-plugman/fetch.spec.js file moved to integration-tests/plugman_fetch.spec.js now I believe. Worth noting that we are doing a big push to move away from I/O-heavy integration tests as much as possible, and instead write out unit tests for each module. It'd be nice if you could follow that pattern in this PR as well. I'm also happy to help with that if you want.

@goya goya closed this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants