From 8e38e274cdd140717766fc43a4b28934f4106e64 Mon Sep 17 00:00:00 2001 From: Jarrad Whitaker Date: Tue, 24 Oct 2017 10:38:55 +1100 Subject: [PATCH 1/3] Test Node 8 with Travis --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index aec9bd618..54e131f74 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,7 @@ git: node_js: - "4" - "6" + - "8" install: - git clone https://github.com/apache/cordova-js --depth 10 - git clone https://github.com/apache/cordova-fetch --depth 10 From 0a704ab17d420273d95c6efeeee3cc7b7774d6f3 Mon Sep 17 00:00:00 2001 From: Jarrad Whitaker Date: Tue, 24 Oct 2017 10:51:26 +1100 Subject: [PATCH 2/3] fix error test on Node 8 --- spec/cordova/util.spec.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/cordova/util.spec.js b/spec/cordova/util.spec.js index 08b0a16b1..40fcf5df5 100644 --- a/spec/cordova/util.spec.js +++ b/spec/cordova/util.spec.js @@ -312,8 +312,9 @@ describe('util module', function () { describe('getPlatformApiFunction', function () { it('Test 027 : should throw error informing user to update platform', function () { - expect(function () { util.getPlatformApiFunction('some/path', 'android'); }).toThrow(new Error // eslint-disable-line func-call-spacing - ('Uncaught, unspecified "error" event. ( Using this version of Cordova with older version of cordova-android is deprecated. Upgrade to cordova-android@5.0.0 or newer.)')); + expect(function () { util.getPlatformApiFunction('some/path', 'android'); }).toThrowError( + /(Uncaught, unspecified|Unhandled) "error" event. \( Using this version of Cordova with older version of cordova-android is deprecated\. Upgrade to cordova-android@5\.0\.0 or newer.\)/ + ); }); it('Test 028 : should throw error if platform is not supported', function () { From 39bd6d747fe6d352e32d34bdd77b511e0202a5fb Mon Sep 17 00:00:00 2001 From: Jarrad Whitaker Date: Tue, 24 Oct 2017 11:01:31 +1100 Subject: [PATCH 3/3] Add Node 8 to Appveyor --- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 535f54682..83f76fd51 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -5,6 +5,7 @@ environment: matrix: - nodejs_version: "4" - nodejs_version: "6" + - nodejs_version: "8" install: - ps: Install-Product node $env:nodejs_version