Dependency cleanup #611
Merged
Dependency cleanup #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test failures are unrelated. https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#update-and-pin-dependencies does have a note about not updating elementtree to 0.16, but it seems like we already had it that version so maybe that problem is gone now? |
|
Tested locally, works! |
brodycj
pushed a commit
to brodycj/cordova-lib
that referenced
this pull request
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove several dependencies that are no longer used directly by this module.
Update several other dependencies to their latest versions. No more deprecation warnings on install!
What testing has been done on this change?
All tests passed locally