New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cleanup #611

Merged
merged 3 commits into from May 2, 2018

Conversation

Projects
None yet
2 participants
@dpogue
Member

dpogue commented Apr 27, 2018

What does this PR do?

Remove several dependencies that are no longer used directly by this module.
Update several other dependencies to their latest versions. No more deprecation warnings on install!

What testing has been done on this change?

All tests passed locally

dpogue added some commits Apr 27, 2018

@stevengill

This comment has been minimized.

Contributor

stevengill commented Apr 27, 2018

I think the test failures are unrelated. https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#update-and-pin-dependencies does have a note about not updating elementtree to 0.16, but it seems like we already had it that version so maybe that problem is gone now?

@stevengill stevengill merged commit 9fcf84b into apache:master May 2, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@stevengill

This comment has been minimized.

Contributor

stevengill commented May 2, 2018

Tested locally, works!

@dpogue dpogue deleted the dpogue:dependency-cleanup branch May 16, 2018

brodybits added a commit to brodybits/cordova-lib that referenced this pull request Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment