Start 8.1.x minor release #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be replaced at some point with a more dynamic method of looking up platform engines.
Dependency cleanup
Also removed before_install from Travis configuration since Node 6 already comes with npm 3 there
CB-14065: Drop support for Node 4 and add Node 10 to CI
…lugin remove sequentially
…ers and update cordova-browser to 5.0.3
There was a lot of sub-optimal error handling in the tests.
Instead of handling Promise rejection and resolution ourselves, we now
just return them from the test functions and let Jasmine handle them.
Moreover, this also fixes tons of negative tests that looked something like this:
f().then(function () {
expect('foo').toBe('bar');
}).catch(function (err) {
expect('' + err).toMatch('some message');
});
Problems being:
- `expect('foo').toBe('bar')` is less obvious than `fail(...)`
- catches its own Error from the `.then` only to fail because `err` is missing
- Does not check that err is an Error and that the message is in `.message`
So these were normalized to look like this:
f().then(function () {
fail('Expected promise to be rejected');
}).catch(function (err) {
expect(err).toEqual(jasmine.any(Error));
expect(err.message).toMatch('some message');
});
All in all, this commit has the following benefits:
- Removes 700 LOC w/out removing any testing
- Improves output when async tests fail
- Should make async tests less error prone
- Reduces Q-API usage to prepare for removal of Q (CB-14159)
These tests tended to cause spurious fails on CI. Hopefully, this commit will stabilize them. Noteworthy changes include: - Reset test files before each test - Don't disguise setup/teardown as tests - Test 020 was dropped since it was actual a weaker version of 019 - Compare objects instead of JSON strings - Don't use reserved words as variable names - Reduce test duration by about 50% - Fix linting errors - Remove shelljs usage - DRY and simplify code - 200 LOC less
One test in pkgJson-restore.spec did NOT wait for the promise returned by `prepare` to be resolved before continuing with other tasks. Especially on Windows this could lead to EBUSY failures during cleanup and in turn to failures during following tests. Note: The order of emptyPlatformList() and prepare() does not seem to matter. Thus I chose the variant that was used throughout all other tests.
CB-13055 Fold all fetch options to `true`
This uses junctions whenever creating directory symlinks on Windows since that does not require any special privileges.
* Improve plugman/uninstall.js messages * Adapt plugman_uninstall.spec.js to new error messages
CB-14243: change dash to underscore for save-exact key reference
This new reporter gives a better idea which tests are currently running, how long individual tests take and during which tests output occurred. All of this information is especially helpful when tests are run in CI.
Previously, the timeout defined by setDefaultTimeout did not apply for beforeAll and afterAll blocks. This change fixes that. The new implementation makes use of the fact that Jasmine processes beforeAll in FIFO order and afterAll in LIFO order.
Minor cleanup of the imports in HooksRunner.spec. No functional changes.
Test 012 sporadically takes slightly longer than the current default timeout of 10s, so this increases the timeout for this test to 20s. Related to apache#642
Covers a few more cases and reduces maintenance for us.
Only warn about "too long shebang" if the file really starts with one
This partially reverts commit 61395d2 but keeps Node.js 10 in AppVeyor CI and Travis CI
- fs-extra@4 needed to support deprecated Node.js version 4 - fs-extra currently not used outside of spec & integration-tests
raphinesse
approved these changes
Sep 14, 2018
brodycj
changed the title
brodycj
pushed a commit
to brodycj/cordova-lib
that referenced
this pull request
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
What does this PR do?
Start 8.1.0 minor release, based on changes from
masterthrough 22 August, with the following additions:Motivations for minor release:
npm auditissues that show up in 8.0.0, as already done inmasterbranchmaster, including 30% shorter runtime in fetch.spec.js (3be60ef)srcalong with the other changes inmasterup to 3be60ef (30% shorter runtime in fetch.spec.js)What testing has been done on this change?
npm auditshows 0 vulnerabilitiescoho audit-license-headers -r libshows no missing license headerscoho check-license -r libshows no invalid licensesHow to merge
In case this proposal is accepted, it is desired to push these commits into a new
8.1.xbranch. @brodbits would like to handle this step.Checklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.