Cordova Lib Release Preparation (Cordova 9) #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cordova-common@^3.1.0 - cordova-create@^2.0.0 - cordova-fetch@^2.0.0 - cordova-serve@^3.0.0
- codecov@^3.2.0 - delay@^4.1.0
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
npm >= 5 automatically prunes any unsaved packages during installation (see npm/npm#16853). Therefore, installing platforms and plugins without saving them to package.json is essentially broken right now.
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 50 50
Lines 2666 2666
=======================================
Hits 2294 2294
Misses 372 372
Continue to review full report at Codecov.
|
Property is unused since 9f1fbf4
raphinesse
approved these changes
Mar 13, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Mar 13, 2019
|
Thanks @raphinesse ! I will be merging this PR and not squashing. I can keep these commits under this one PR. |
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
all
Motivation and Context
Cordova 9 Release
Description
This PR contains final preparations for the Cordova 9 release goals.
See Cordova 9 Release Plan.
cordova-common@^3.1.0cordova-create@^2.0.0cordova-fetch@^2.0.0cordova-serve@^3.0.0fs-extra@^7.0.1globby@^9.1.0init-package-json@^1.10.3read-chunk@^3.1.0semver@^5.6.0underscore@^1.9.1eslint@^5.15.1eslint-config-semistandard@^13.0.0eslint-config-standard@^12.0.0eslint-plugin-import@^2.16.0eslint-plugin-node@^8.0.1eslint-plugin-promise@^4.0.1eslint-plugin-standard@^4.0.0codecov@^3.2.0delay@^4.1.0jasmine@^3.3.1nyc@^13.3.0shelljs@^0.8.3shelljsdependency has been added as adevDepoendencyto fix the failing tests. Tests started to fail withcordova-common@3.x. Theshelljsdependency had been removed fromcordova-common@3.xandcordova-librelied on this dependency.Platform Pinning Bump
All platform pinnings were bumped and increase semver matches to include minors.
Testing
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))