Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetName to paramter to getBuildProperty #109

Merged
merged 2 commits into from May 14, 2020
Merged

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Apr 19, 2020

Allow to get property only of one target similar to updateBuildProperty.

Closes #108

Allow to get property only of one target similar to updateBuildProperty.

Closes #108
@NiklasMerz NiklasMerz requested a review from erisu Apr 19, 2020
erisu
erisu approved these changes May 1, 2020
Copy link
Member

@erisu erisu left a comment

LGTM

@erisu
Copy link
Member

erisu commented May 1, 2020

@timbru31 If you have time, you think you can give a second review?

lib/pbxProject.js Outdated Show resolved Hide resolved
Copy link
Member

@timbru31 timbru31 left a comment

LGTM, one minor style suggestion.

Co-authored-by: Tim Brust <github@timbrust.de>
@erisu erisu merged commit cd6f86f into master May 14, 2020
8 checks passed
@erisu erisu deleted the getBuildProperty branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants