Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with pbxFile extension #31

Merged
merged 2 commits into from Dec 11, 2018

Conversation

@brodybits
Copy link

@brodybits brodybits commented Dec 11, 2018

where pbxFile extension was being set to undefined

and add new test case to verify the bug fix

NOTE: These changes were originally part of PR #12,
extracted here by @brodybits (Christopher J. Brody).

/cc @n1ru4l @kspearrin

kspearrin and others added 2 commits Dec 11, 2018
where pbxFile extension was being set to 'undefined'

and add new test case to verify the bug fix

NOTE: These changes were originally part of
#12 (cordova-node-xcode PR #12),
extracted here by @brodybits (Christopher J. Brody).

Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
Co-authored-by: Christopher J. Brody <brodybits@litehelpers.net>
Christopher J. Brody
for the sake of consistency with the other test cases
@brodybits
Copy link
Author

@brodybits brodybits commented Dec 11, 2018

All changes except for the quick test fix by @brodybits were already reviewed in PR #12. Merging now to help unblock the upcoming release.

@brodybits brodybits merged commit b732ae5 into apache:master Dec 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brodybits brodybits deleted the brodybits:pbxFile-extension-bugfix branch Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants