Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13592 Fixed bug where comment is not removed on removing embedded frameworks. #5

Merged
merged 1 commit into from May 22, 2018

Conversation

@kelvinhokk
Copy link
Contributor

@kelvinhokk kelvinhokk commented Nov 1, 2017

Currently after adding an embedded framework, 4 entries are added to the PBXBuildFileSection.

        "128CD4F705D24987A12F213E": {
          "isa": "PBXBuildFile",
          "fileRef": "021AA25C78F942DA94C24904",
          "fileRef_comment": "EmbedThirdParty.framework"
        },
        "128CD4F705D24987A12F213E_comment": "EmbedThirdParty.framework in Frameworks",
        "B9B17AE7AA7C4663BA933B64": {
          "isa": "PBXBuildFile",
          "fileRef": "021AA25C78F942DA94C24904",
          "fileRef_comment": "EmbedThirdParty.framework",
          "settings": {
            "ATTRIBUTES": ["CodeSignOnCopy"]
          }
        },
        "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",

After calling removeFramework function, the current existing code will incorrectly leave a orphan entry in the PBXFileSection:

        "B9B17AE7AA7C4663BA933B64_comment": "EmbedThirdParty.framework in Embed Frameworks",

This pull request fixes this issue, and adds a relevant unit test in removeFramework.js

@kelvinhokk kelvinhokk changed the title Fixed bug where comment is not removed on removing embedded frameworks. CB-13592 Fixed bug where comment is not removed on removing embedded frameworks. Nov 22, 2017
@SPLUMEJI

This comment has been minimized.

Copy link

@SPLUMEJI SPLUMEJI commented on 3d5657e Dec 7, 2017

This comment has been minimized.

Copy link

@SPLUMEJI SPLUMEJI replied Dec 7, 2017

This comment has been minimized.

This comment has been minimized.

@shazron shazron merged commit d1ff114 into apache:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants