Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR] Add new optional paramter to pbxProject.addTarget #79

Merged
merged 3 commits into from Apr 9, 2020
Merged

[MAJOR] Add new optional paramter to pbxProject.addTarget #79

merged 3 commits into from Apr 9, 2020

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Nov 5, 2019

This allows plugins to set bundle ids for extensions.

Necessary with cordova-ios >= 5 after the introduction of $(PRODUCT_NAME) in https://github.com/apache/cordova-ios/pull/409/files. Plugins with extension now need to set their bundleId to make them work in Xcode.

This allows plugins to set bundle ids for extensions.
@NiklasMerz NiklasMerz marked this pull request as ready for review Dec 16, 2019
@brodybits brodybits changed the title Add new optional paramter to pbxProject.addTarget [MAJOR] Add new optional paramter to pbxProject.addTarget Dec 16, 2019
Copy link

@brodybits brodybits left a comment

Thanks @NiklasMerz for the contribution. I think this proposal should not be considered for review until we sort out the root cause and get the bundle id fixed on cordova-ios. I would also like to keep this proposal for consideration as part of a new major release. Thanks again @NiklasMerz for all of your efforts.

@brodybits
Copy link

brodybits commented Mar 29, 2020

Any news on this work or the issue on iOS?

@brodybits brodybits mentioned this pull request Mar 29, 2020
1 task
@NiklasMerz
Copy link
Member Author

NiklasMerz commented Mar 30, 2020

I need this for hooks in my plugin that needs to change the targets in the Xcode project. See GEDYSIntraWare/cordova-plugin-call-directory@9ad709a

test/addTarget.js Outdated Show resolved Hide resolved
@NiklasMerz NiklasMerz requested review from timbru31 and brodybits Apr 2, 2020
@timbru31
Copy link
Member

timbru31 commented Apr 2, 2020

Should we aim to merge the PR, even if apache/cordova-ios#538 is not yet fixed?

@NiklasMerz
Copy link
Member Author

NiklasMerz commented Apr 2, 2020

I think yes. Some plugins need this package as a dependency for hooks that modify only one target. So getting this in the upcoming release would be good. apache/cordova-ios#538 is no dependency for this change just needed for the same problem.

I cannot get my head around how to fix apache/cordova-ios#538 properly but this is definitly an issue and I hacked around it. Cordova iOS definitly causes issues for the tiny percentage of apps that use more than the default target (watch, share, calldirectory extensions). But we should discuss this in the issue.

Copy link
Member

@timbru31 timbru31 left a comment

LGTM - only reviewed code wise though. I know that some other projects depend on this project (even without the Cordova scope/context), so this is a good addition.

@NiklasMerz
Copy link
Member Author

NiklasMerz commented Apr 7, 2020

Works together with #106 and apache/cordova-ios#820 to fix apache/cordova-ios#538

Should we consider it now?

@NiklasMerz NiklasMerz added this to the 3.0 milestone Apr 8, 2020
erisu
erisu approved these changes Apr 9, 2020
Copy link
Member

@erisu erisu left a comment

LGTM

@erisu erisu merged commit 022c69e into apache:master Apr 9, 2020
1 check passed
@NiklasMerz NiklasMerz deleted the bundleid branch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants