[MAJOR] Add new optional paramter to pbxProject.addTarget#79
[MAJOR] Add new optional paramter to pbxProject.addTarget#79erisu merged 3 commits intoapache:masterfrom GEDYSIntraWare:bundleid
Conversation
This allows plugins to set bundle ids for extensions.
brody2consult
changed the title
brody2consult
left a comment
brody2consult
left a comment
There was a problem hiding this comment.
Thanks @NiklasMerz for the contribution. I think this proposal should not be considered for review until we sort out the root cause and get the bundle id fixed on cordova-ios. I would also like to keep this proposal for consideration as part of a new major release. Thanks again @NiklasMerz for all of your efforts.
|
Any news on this work or the issue on iOS? |
|
I need this for hooks in my plugin that needs to change the targets in the Xcode project. See GEDYSIntraWare/cordova-plugin-call-directory@9ad709a |
|
Should we aim to merge the PR, even if apache/cordova-ios#538 is not yet fixed? |
|
I think yes. Some plugins need this package as a dependency for hooks that modify only one target. So getting this in the upcoming release would be good. apache/cordova-ios#538 is no dependency for this change just needed for the same problem. I cannot get my head around how to fix apache/cordova-ios#538 properly but this is definitly an issue and I hacked around it. Cordova iOS definitly causes issues for the tiny percentage of apps that use more than the default target (watch, share, calldirectory extensions). But we should discuss this in the issue. |
timbru31
left a comment
timbru31
left a comment
There was a problem hiding this comment.
LGTM - only reviewed code wise though. I know that some other projects depend on this project (even without the Cordova scope/context), so this is a good addition.
|
Works together with #106 and apache/cordova-ios#820 to fix apache/cordova-ios#538 Should we consider it now? |
4 participants
This allows plugins to set bundle ids for extensions.
Necessary with cordova-ios >= 5 after the introduction of $(PRODUCT_NAME) in https://github.com/apache/cordova-ios/pull/409/files. Plugins with extension now need to set their bundleId to make them work in Xcode.