Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added allowEdit support for android #12

Closed
wants to merge 11 commits into from

Conversation

riyazMuhammad
Copy link

Changes

  1. Allows user to crop selected image from gallery or captured from camera if allowEdit is set to true
  2. Fallback if device does not support com.android.camera.action.CROP

@riyazMuhammad riyazMuhammad mentioned this pull request Feb 12, 2014
Closed
@riyazMuhammad
Copy link
Author

Hi @agrieve did you find any more conflicts merging this ?

@confile
Copy link

confile commented Apr 28, 2014

When will this get merged?

@asfgit asfgit closed this in c7d88e8 Apr 29, 2014
@l0calgost
Copy link

Since confile's question isn't answered yet, I'd like to know, when this will be available, too??

@confile
Copy link

confile commented Jul 10, 2014

Since there is no way to send you issues I write it here.

When using Android and image as PNG from Camera auto rotation does not work even if it is set to true. This is a bug. It works fine on iOS.

@clelland
Copy link
Contributor

@woozzel, it looks like this was merged in just after v0.2.9 was released, and the code is present in the v0.3.0 release, which is available now from plugins.cordova.io. You can upgrade your existing camera plugin from the command line with

cordova plugin rm org.apache.cordova.camera
cordova plugin add org.apache.cordova.camera

@clelland
Copy link
Contributor

@confile, you can file issues on our JIRA issue tracker here

You'll have to create a (free) account, if you haven't already, but anyone can submit new issues to the project.

@roysG
Copy link

roysG commented Apr 17, 2015

there is still problem with cropping in android, when choose to capture image.
I can׳t crop, why ?

@fguerin
Copy link

fguerin commented Sep 18, 2015

Same as @roysG, I'm not able to edit the captured image.

@bitcoinvsalts
Copy link

Same as @roysG, I'm not able to edit the captured image. I have a Nexus 4.

@jcesarmobile
Copy link
Member

Read the quirks

Android Quirks
Android also uses the Crop Activity for allowEdit, even though crop should work and actually pass the cropped image back to Cordova, the only one that works consistently is the one bundled with the Google Plus Photos application. Other crops may not work.

So, you have any app that can crop like google plus photos? in case you have it, does it open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants