Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change CameraOptions of README.md in ios #264

Merged
merged 1 commit into from Feb 11, 2018

Conversation

ferretdayo
Copy link
Contributor

Platforms affected

iOS

What does this PR do?

it modified on README.md.
it may be wrong.

In README.md

  • allowEdit is true on default in CameraOptions.

but, actually allowEdit default value is false.
In a part of www/Camera.js

cameraExport.getPicture = function(successCallback, errorCallback, options) {
    options = options || {};

    var allowEdit = !!options.allowEdit;    // if do not set value, this allowEdit is false
};

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

316 tests run, 28 skipped, 0 failed.

@ferretdayo ferretdayo changed the title change CameraOptions of README.md for in ios change CameraOptions of README.md in ios Apr 29, 2017
@jcesarmobile jcesarmobile merged commit e25aed9 into apache:master Feb 11, 2018
@jcesarmobile
Copy link
Member

Thanks for the PR.
Next time please, create an issue on JIRA even if the change is small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants