Skip to content
Permalink
Browse files
CB-5977: Removing the Android Geolocation Code. Mission Accomplished.
  • Loading branch information
infil00p committed Feb 28, 2014
1 parent 99945c5 commit ab8a448e52b0c2cc05fabe3e0d0cff3fd859b020
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 566 deletions.
@@ -16,38 +16,11 @@ xmlns:android="http://schemas.android.com/apk/res/android"
<!-- android -->
<platform name="android">

<js-module src="www/Coordinates.js" name="Coordinates">
<clobbers target="Coordinates" />
</js-module>

<js-module src="www/PositionError.js" name="PositionError">
<clobbers target="PositionError" />
</js-module>

<js-module src="www/Position.js" name="Position">
<clobbers target="Position" />
</js-module>

<js-module src="www/geolocation.js" name="geolocation">
<clobbers target="navigator.geolocation" />
</js-module>

<config-file target="res/xml/config.xml" parent="/*">
<feature name="Geolocation">
<param name="android-package" value="org.apache.cordova.geolocation.GeoBroker"/>
</feature>
</config-file>

<config-file target="AndroidManifest.xml" parent="/*">
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
</config-file>

<source-file src="src/android/GeoBroker.java" target-dir="src/org/apache/cordova/geolocation" />
<source-file src="src/android/GPSListener.java" target-dir="src/org/apache/cordova/geolocation" />
<source-file src="src/android/NetworkListener.java" target-dir="src/org/apache/cordova/geolocation" />
<source-file src="src/android/CordovaLocationListener.java" target-dir="src/org/apache/cordova/geolocation" />

</platform>

<!-- amazon-fireos -->

This file was deleted.

This file was deleted.

5 comments on commit ab8a448

@hzulla
Copy link

@hzulla hzulla commented on ab8a448 May 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my ignorance, but: Why?

@infil00p
Copy link
Member Author

@infil00p infil00p commented on ab8a448 May 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been replaced because the browser has a working geolocation API, and this API no longer offers the user anything that the browser doesn't already have.

@luiscruz
Copy link

@luiscruz luiscruz commented on ab8a448 Aug 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this okay for all versions of Android? If not, which ones are compatible?

@des63rus1
Copy link

@des63rus1 des63rus1 commented on ab8a448 Feb 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in browser geolocation API in 4.4
if enableHighAccuracy isn't set to true, the emulator won't return anything; it doesn't matter if you have your GPS on or not.
High accuracy: because you want the emulator to work, you set enableHighAccuracy to true, but this will mean that you must keep the GPS turned on.
So you cant get position with GPS off

@msrameshp
Copy link

@msrameshp msrameshp commented on ab8a448 Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the android browser based API also support lastKnownLocation feature provided previously in this plugin

Please sign in to comment.