Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSLocationWhenInUseUsageDescription documentation (ios12+ config.xml) #142

Closed
vousys opened this issue Jan 22, 2019 · 5 comments
Closed

Fix NSLocationWhenInUseUsageDescription documentation (ios12+ config.xml) #142

vousys opened this issue Jan 22, 2019 · 5 comments

Comments

@vousys
Copy link

@vousys vousys commented Jan 22, 2019

Guys for Phonegap users, in config.xml fix the documentation, they should add the platform="ios" to the code, like this:

<edit-config  platform="ios"  target="NSLocationWhenInUseUsageDescription" file="*-Info.plist" mode="merge">
    <string>need location access to find things nearby</string>
</edit-config>

instead of


<edit-config   target="NSLocationWhenInUseUsageDescription" file="*-Info.plist" mode="merge">
    <string>need location access to find things nearby</string>
</edit-config>
@janpio
Copy link
Member

@janpio janpio commented Jan 23, 2019

This repo does not have any documentation regarding usage in Phonegap. What are you referring to?

@vousys
Copy link
Author

@vousys vousys commented Jan 23, 2019

@janpio Here https://github.com/apache/cordova-plugin-geolocation#ios-quirks the plugin says "To add this entry into the info.plist, you can use the edit-config tag in the config.xml like this:"
And for phonegap users or any other cordova plugin users, like ionic, they need to add the platform="ios" to get this variable compile.

Is only add this to the code : platform="ios"

@janpio
Copy link
Member

@janpio janpio commented Jan 23, 2019

Ah, so what you write also applies to all normal Cordova users?
Is it possible that the docs assumed you put it inside a <platform name="ios">...</platform> element? Does this also work?

@vousys
Copy link
Author

@vousys vousys commented Jan 23, 2019

no, that seems to not be working anymore, because yesterday Apple reject me an app who has that syntax <platform name="ios">...</platform>

@janpio janpio changed the title Fix Documentacion for phonegap users // ios12+ config.xml Fix NSLocationWhenInUseUsageDescription documentation (ios12+ config.xml) Jan 23, 2019
@timbru31
Copy link
Member

@timbru31 timbru31 commented Mar 30, 2020

Closing as this is about PhoneGap and not Cordova - a "fix" for PhoneGap users is included in this issue, too.

@timbru31 timbru31 closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants