New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings does not export cordova.InAppBrowser.open #300
Comments
There are already several typing related PRs. Can you check those to see if those fix the issue you are describing? |
Thanks for the super quick response. |
Okay, can you leave a review on that PR please? |
Not sure I understand what you mean. can you please elaborate? |
### Platforms affected n/a - development with TypeScript ### What does this PR do? Updates the typings to match the latest published version on DefinitelyTyped. See DefinitelyTyped/DefinitelyTyped#17192 and https://stackoverflow.com/q/42095516/1902598 ### What testing has been done on this change? Project compiles again ;) ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - n/a: Added automated test coverage as appropriate for this change. fixes #300
Hi,
This is a great plugin! thanks for all the hard work!
In the documentation it is suggested to do the following:
window.open = cordova.InAppBrowser.open;
However when using typescript this is not possible without using
any
or something similar.Please add the relevant declaration to the types file.
The text was updated successfully, but these errors were encountered: