not work ios13 InAppbrowser select target _blank #492
Assignees
Labels
Comments
|
Following Code is as follows:
|
|
Is this reproducible in a new, plain Cordova app? A minimal reproduction repository would really help to debug and later fix this issue. More information on how to create one: https://github.com/apache/cordova-contribute/blob/master/create-reproduction.md |
|
@janpio Thanks for the quick reply! Here you can find my minimal reproduction repo (one weird sidenote, on ios 12 it is an UIWebView and not an WkWebView) |
|
Thanks @dlwsacrez. @megumih Did you problem also concern usage with |
|
@dlwsacrez and @janpio I try this one soon |
|
please help me! I'm using this plugin. how to use usewkwebview=yes? |
|
not working... |
|
I've done some preliminary investigation into this use my test harness project for this plugin. Firstly I can confirm the issue is consistently reproducible: In contrast, the UIWebView implementation on iOS ( The These can be seen in the initial startup of the test app: Xcode console output during app startupThe log output when opening the IAB using both the WKWebView & UIWebView implementations also show the Xcode console output using UIWebViewXcode console output using WKWebViewThe question is: is the behaviour observed with the WKWebView implementation a bug with this plugin or a bug with the iOS 13 Beta? Here is the relevant extract from my iPhone 7 running iOS 13 Beta 2 (17A5508m) during the period where the WKWebView window is being shown then disappears: iPhone 7 console output using WKWebView implementation (during issue)I can see no obvious cause indicated in that log, although several errors are logged. For comparison here's the iPhone console output while opening the IAB using the UIWebView implementation: iPhone 7 console output using UIWebView implementation |
|
Any update on this issue? |
|
Just regression tested on iOS 13 Beta 3 (17A5508m) (note the build number is the same as Beta 2) and the issue is still present. |
|
oh.... |
I have the same issue on iOS 12.4 :( |
This comment has been minimized.
This comment has been minimized.
|
BTW I have noticed that there is no bug when you use https://github.com/ionic-team/cordova-plugin-ionic-webview. But when you use https://github.com/apache/cordova-plugin-wkwebview-engine bug exists. |
|
@yoldar That's good to know. So maybe the underlying WKWebView implementation (rather than this plugin itself) is the cause of this. Also can be a workaround. |
|
@yoldar I can't reproduce the issue on ios 12.4, can you make a demo repo? |
|
now,I'm working IOS 13 beta 5. |
|
I have found very strange behavior. My application based on VueJs framework. I tried to debug this bug and have found that using VueJs and InAppBrowser + cordova-plugin-wkwebview-engine is always behave like this. If I run |
|
OMG Finally I have found solution. Thanks to @oarsheo ionic-team/cordova-plugin-ionic-webview#140 So I removed |
|
Downgrading the WKView might solve this issue. https://ionicframework.com/docs/v3/wkwebview/ you can do it by adding this in config.xml
|
|
Has anyone got any update on this? Downgrading to use CDVUIWebViewEngine is not really a permanent solution. |
|
Setting Eventually I found out that it seems to work when starting a new (blank) project, which made me realise that there must be a conflict with another plugin installed OR I simply didn't have the latest version installed. The latter turned out to be the case. I managed to fix it as follows:
Btw, the browser does still crash when setting usewkwebview=yes, so if that's a requirement then this won't work. There is also Enterprise Support available from Ionic for this plugin which might work if you don't want to wait: https://ionicframework.com/docs/enterprise/inappbrowser#inappbrowser |
|
@RikdeVos Interestingly for mine, before following your step, it wasn't crashing but rather the inappbrowser will pop up for less than a sec, then disappeared. After those 4 steps, app starts crashing during open. Wondering how you install the 3.1.0 for inappbrowser? I just use the github link. What's weird is the current prod version of my app is build on top of inappbrowser 3.0.0 and Cordova 3, which has no issues at all. Tested on both iOS 13.0 beta and 13.1 beta. |
|
I can reproduce this with This is my simple demo app: https://github.com/NiklasMerz/repro-ios13iab The IAB closes on iOs 13 and stays open on iOS 12. @yoldar How did you get Ionic WKWebView with IAB and |
|
Alrighty, found my solution. So, I'm not running with WKWebKit, but I'm running a combination of Cordova iOS 4.5 + inappbrowser 3.0.0, which was the cause of my issue. Upgrading to Cordova iOS 5.0.0 solves it. |
|
This is probably releated to some changes in iOS 13 regarding ViewControllers. Some links I found: |
|
Does anybody have an idea where to look? @dpa99c I have been debugging this for hours and still don't have a clue what happens. |
|
I found a soltution (partially) ! Honestly it's more of a workaround. Like found in my links iOS 13 brings some changes to how modals work. These changes are in effect if the app is built using Xcode 11. So I tried building the app with Xcode 10 and uploaded it to testflight. Et voilà the app works on a iOS 13 device with this build from Xcode 10! Looks like some of the changes affect the IAB modal. I still don't know which one because I couldn't find a viewctrl that has the presentationstyle automatic that has changed. I will keep looking for a solution. |
|
Hi, Please is there anyone who can told us when this fix will be available, it's really urgent :/ we are going soon to publish the app and we have some feature that doesn't work. Thanks in advance. |
Try to add plugin directly from repo: cordova plugin rm cordova-plugin-inappbrowser |
|
If using package.json add the package like this:
|
I only updated my plugin to 3.1.0 version and It works good. |
This absolutely worked for me. 3.1.0 is the winner. |
|
cordova plugin add https://github.com/apache/cordova-plugin-inappbrowser.git worked for me too. Thanks for the fix and immediate workaround! |
|
Hi @amit777 But for me doesn't work. I use this code: How can I do? How do you use this? My plugin version is: 3.1.1-dev |
|
@ambr89 You may need to delete the iOS platform and add it again to update the plugin code. |
|
I've resolve, Thanks all! |
|
Had the problem on our app. Added this branch and reinstalled the plugin and everything work! IAB stay open! Thanks! |
|
I tried this and this has resolved my problem with inappbrowser in ios13 , the page is loading with target = _blank ,how ever, I'm facing 2 issues after updating the inappbrowser :
I'm using I have if I use toolbar : 'yes', the page bottom issue will be gone. so this only happens with toolbar = no . I did not have this issue before updating to this version |
|
@charlesw325 Issues with the grey statusbar are discussed seperately in #546 |
|
I have latest version of plugin installed with usewkwebview : "yes" I found issue with Xcode 11 build running on iOS 13 simulator. InAppBrowser opens and closed without pressing close button freezing the app. Anybody else facing such issue? |
3 tasks
|
I tried to add plugin for my ionic app: cordova plugin rm cordova-plugin-inappbrowser then i tried : then i added: then i removed all and tried : And all the tests were a failure. Plugin not working with IOS 13.2. Anyone could help, please ? |
|
I am using vue-onsen. I tried to remove and install again cordova-plugin-inappbrowser, then add and it works. |
|
my app in ionic 3 has been rejected by Apple due to some bugs I found that buttons they were saying having issue was opening external URLS ionic (Ionic CLI) : 4.12.0 (C:\Users\Arun\AppData\Roaming\npm\node_modules\i Cordova: cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1) |
|
This issue is not intended for support. Please go to Cordova slack for more help. Did you try to add the latest version from the master branch? |
|
Thank you @NiklasMerz, this worked perfectly! |
|
Please note this is not an officially released version. It's just the latest development code with this fix. We are working on a new version with this fix, soon. |
|
Is there any update to this? I followed all the various steps and suggestions, however, it just continues to open and close. the only thing that I've gotten it to somewhat work is to have the target be |
|
@ctfrancia after fighting with the same issue (still not working with newest IAB version in iOS 13.3), I found out that in our case a third party library for authentication (hello.js) seems to be responsible for it. It seems to have some cordova handling but is not compatible with the new version of IAB. |
|
@trampi hm thanks, I'll take a look into that. I don't believe we have any authentication like that in my app but I'll double-check |
Do we have to use the 'usewkwebview=yes' option if we are using wk webview, I can't find that mentioned anywhere in the plugin page I am facing the same issue in ios 13.5 |
|
@msd117 Hey, I had the same issue which popped up on iOS 13.5. I fixed it by following yoldar's suggestion
|
|
this code not working in ios build.... |
|
Please open a new issue if you still have the same issue. We don't really monitor closed issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Bug Report
I'm creating ios13 app.
But ios13Beta2 is not working in InAppBrowser.
so select param '_blank', this app is crash.
This is error detail.
[TraitCollection] Class _UIFullscreenPresentationController overrides the -traitCollection getter, which is not supported. If you're trying to override traits, you must use the appropriate API.
My ionic environment
Ionic:
Ionic CLI : 5.0.3 (/Users/syoken/.nvm/versions/node/v12.4.0/lib/node_modules/ionic)
Ionic Framework : ionic-angular 3.9.6
@ionic/app-scripts : 3.2.4
Cordova:
Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : ios 5.0.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 1.2.1, (and 14 other plugins)
Utility:
cordova-res : not installed
native-run : not installed
System:
ios-sim : 8.0.1
NodeJS : v12.4.0
npm : 6.9.0
OS : macOS Catalina
Xcode : Xcode 11.0 Build version 11M337n
please tell me!
The text was updated successfully, but these errors were encountered: