Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android,ios): Support for passing in request headers #115

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sanketmehta7
Copy link

Support for passing request headers only for android.
User need to pass comma separated headers, with their key, values separated by :
Eg: cordova.InAppBrowser.open("http://apache.org", "_self", 'location=no','custom-h1:asd,h1:xyz');

@TakkuzOld
Copy link

This would be really useful, mostly on WP8, (if it will be possible) where file-transfer fails.

@olivercs
Copy link

olivercs commented Aug 8, 2016

Very useful when you have to send a token or Authorization header to access to a resource.

@kodeine
Copy link

kodeine commented Nov 10, 2016

@sanketmehta7 can you please fix the conflicts so this can be merged?

@ghost
Copy link

ghost commented Dec 13, 2016

Would there be any chance for ios as well?

@mrtnjln
Copy link

mrtnjln commented Jan 17, 2017

Any news on this ?
I can't build on Xcode (missing .h declaration for navigateToNew method).

@ramses80
Copy link

hellow.julymartin.can.you.herme.or.not

@infil00p
Copy link
Member

This is an API change and should be discussed on the list, or at the very least have a JIRA issue attached to it. Also, the conflicts are definitely going to prevent this from getting merged as-is.

@rdksgit
Copy link

rdksgit commented Jun 13, 2018

Does this work with ios

@daveshirman
Copy link

@rdksgit Nope, using this forked version causes the iOS build code 65. So basically unless the developer can fix the reason why it causes the build to fail, this plugin is not production ready.

Note: you won't see the build error on Android build, just iOS.

@sanketmehta7 Thanks for this plugin very much. Is there any chance that you will be able to sort the build (causing issue Error 65) any time soon please?

Feedback would be greatly appreciated, thank you.

@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Plugin Pull Requests Sep 16, 2018
@janpio
Copy link
Member

janpio commented Sep 16, 2018

Hey @sanketmehta7 , there seems to be a merge conflict now. Could you maybe fix this? Thanks.

@janpio janpio moved this from 🐣 New PR / Untriaged to 💥 Blocked: Conflict in Apache Cordova: Plugin Pull Requests Sep 16, 2018
@janpio janpio added the feature label Sep 17, 2018
@janpio janpio changed the title Support for passing request headers for android feat(android): Support for passing in request headers Jul 3, 2019
@janpio janpio changed the title feat(android): Support for passing in request headers feat(android,ios): Support for passing in request headers Jul 3, 2019
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard conflicts, which is not a big surprise after so long.
As the feature itself still looks interesting, this should probably be resurrected as a new PR.

@Aiuspaktyn
Copy link

Any news about this PR?

@sanketmehta7
Copy link
Author

will try to create new PR from latest code

@kasp1
Copy link

kasp1 commented Mar 11, 2021

In the meantime, if anyone needs to access an HTTP auth protected site/resource, you can include the creds in the URL, e.g.:

https://username:password@host.name/...

It's got me over this issue for now, so it could help someone else as well.

@iantearle
Copy link

will try to create new PR from latest code

Did you have any luck with this?

@sawaca96
Copy link

Any update?

@lubbo
Copy link

lubbo commented Sep 26, 2023

Hard conflicts, which is not a big surprise after so long.
As the feature itself still looks interesting, this should probably be resurrected as a new PR.

@janpio What about #1024 ?
I'm not changing API but using the options with json and base64 encoding for headers and cookies as well.
Let me know.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apache Cordova: Plugin Pull Requests
🙅 Reviewed, but not approved
Development

Successfully merging this pull request may close these issues.

None yet