New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android,ios): Support for passing in request headers #115
base: master
Are you sure you want to change the base?
Conversation
This would be really useful, mostly on WP8, (if it will be possible) where file-transfer fails. |
Very useful when you have to send a token or Authorization header to access to a resource. |
@sanketmehta7 can you please fix the conflicts so this can be merged? |
Would there be any chance for ios as well? |
Any news on this ? |
hellow.julymartin.can.you.herme.or.not |
This is an API change and should be discussed on the list, or at the very least have a JIRA issue attached to it. Also, the conflicts are definitely going to prevent this from getting merged as-is. |
Does this work with ios |
@rdksgit Nope, using this forked version causes the iOS build code 65. So basically unless the developer can fix the reason why it causes the build to fail, this plugin is not production ready. Note: you won't see the build error on Android build, just iOS. @sanketmehta7 Thanks for this plugin very much. Is there any chance that you will be able to sort the build (causing issue Error 65) any time soon please? Feedback would be greatly appreciated, thank you. |
Hey @sanketmehta7 , there seems to be a merge conflict now. Could you maybe fix this? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard conflicts, which is not a big surprise after so long.
As the feature itself still looks interesting, this should probably be resurrected as a new PR.
Any news about this PR? |
will try to create new PR from latest code |
In the meantime, if anyone needs to access an HTTP auth protected site/resource, you can include the creds in the URL, e.g.:
It's got me over this issue for now, so it could help someone else as well. |
Did you have any luck with this? |
Any update? |
@janpio What about #1024 ? |
Support for passing request headers only for android.
User need to pass comma separated headers, with their key, values separated by :
Eg: cordova.InAppBrowser.open("http://apache.org", "_self", 'location=no','custom-h1:asd,h1:xyz');