New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event name and example param update #31

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rocco
Copy link
Contributor

rocco commented Mar 22, 2014

Some example code failed due to missing arguments, so I added them, also there is no "load" event, must be "loadstop"

@shazron

This comment has been minimized.

Copy link
Contributor

shazron commented Mar 24, 2014

Pulling this in to dev branch - but take note it should be a pull request to the dev branch always for next time.

@rocco

This comment has been minimized.

Copy link
Contributor

rocco commented Mar 24, 2014

sorry, overlooked that

@rocco

This comment has been minimized.

Copy link
Contributor

rocco commented Mar 24, 2014

want me to open another pr on dev?

@shazron

This comment has been minimized.

Copy link
Contributor

shazron commented Mar 24, 2014

no. github should auto-close this soon, I already merged

@asfgit asfgit closed this in 9399ed3 Apr 23, 2014

zachawilson pushed a commit to zachawilson/cordova-plugin-themeablebrowser that referenced this pull request Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment