Skip to content

CB-12479: Add loading spinner for android #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjpearson wants to merge 2 commits into from
+12 −0
Closed

CB-12479: Add loading spinner for android #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec082aa
CB-3750: Add spinner for android
cjpearson Feb 27, 2015
4bd3fc4
CB-12479: Use ProgressBar instead of ProgressDialog
cjpearson Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/android/InAppBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.widget.ImageButton;
import android.widget.ImageView;
import android.widget.LinearLayout;
import android.widget.ProgressBar;
import android.widget.RelativeLayout;
import android.widget.TextView;

Expand Down Expand Up @@ -116,6 +117,7 @@ public class InAppBrowser extends CordovaPlugin {
private InAppBrowserDialog dialog;
private WebView inAppWebView;
private EditText edittext;
private ProgressBar progressBar;
private CallbackContext callbackContext;
private boolean showLocationBar = true;
private boolean showZoomControls = true;
Expand Down Expand Up @@ -988,6 +990,13 @@ public void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType)
main.addView(toolbar);
}

// Progress Bar
progressBar = new ProgressBar(webView.getContext(), null, android.R.attr.progressBarStyleHorizontal);
progressBar.setIndeterminate(true);
progressBar.setVisibility(View.GONE);

main.addView(progressBar);

// Add our webview to our main view/layout
RelativeLayout webViewLayout = new RelativeLayout(cordova.getActivity());
webViewLayout.addView(inAppWebView);
Expand Down Expand Up @@ -1221,6 +1230,7 @@ public void onPageStarted(WebView view, String url, Bitmap favicon) {
} catch (JSONException ex) {
LOG.e(LOG_TAG, "URI passed in has caused a JSON error.");
}
progressBar.setVisibility(View.VISIBLE);
}


Expand Down Expand Up @@ -1248,6 +1258,7 @@ public void onPageFinished(WebView view, String url) {
} catch (JSONException ex) {
LOG.d(LOG_TAG, "Should never happen");
}
progressBar.setVisibility(View.GONE);
}

public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) {
Expand All @@ -1264,6 +1275,7 @@ public void onReceivedError(WebView view, int errorCode, String description, Str
} catch (JSONException ex) {
LOG.d(LOG_TAG, "Should never happen");
}
progressBar.setVisibility(View.GONE);
}

/**
Expand Down