Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #248 delete javascript reference to released media #249

Merged
merged 1 commit into from Apr 3, 2020
Merged

Fix #248 delete javascript reference to released media #249

merged 1 commit into from Apr 3, 2020

Conversation

AgDude
Copy link
Contributor

@AgDude AgDude commented Aug 21, 2019

Platforms affected

All (www change)

Motivation and Context

This removes the javascript reference to released media objects. See #248

Description

Add a success callback to delete media id after it is released by platform specific code.

Checklist

  • I've run the tests to see all new and existing tests pass
  • [NA ] I added automated test coverage as appropriate for this change
  • [ NA] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [Y ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [NA ] I've updated the documentation if necessary

timbru31
timbru31 requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for noticing the bug and a PR - however, I've some feedback.

www/Media.js Show resolved Hide resolved
@timbru31 timbru31 merged commit 3475970 into apache:master Apr 3, 2020
primerib added a commit to primerib/cordova-plugin-media that referenced this pull request Jun 12, 2020
@primerib
Fix apache#248 delete javascript reference to released media (apache#249
9e56363 
)

some js mem management
uaza pushed a commit to quiply/cordova-plugin-media that referenced this pull request Oct 22, 2020
@AgDude @uaza
Fix apache#248 delete javascript reference to released media (apache#249
eb8c171 
)

Co-authored-by: Nate Dudenhoeffer <agdude@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AgDude @timbru31