Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cordova-ios requirement <6.0.0 #261

Merged
merged 4 commits into from Jun 1, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 21, 2020

Platforms affected

ios

Motivation and Context

Cordova-iOS Platform 6.x will have splash screen integrated and no longer needs the plugin.

This PR is intended to be released in a patch to prevent the plugin from being added to the iOS 6.x platform.

Description

  • update plugin.xml
  • update package.json

Testing

  • see CI service

Note

  • This must be released before next major is released.

@erisu erisu added this to the 5.0.4 milestone May 21, 2020
@erisu erisu requested review from dpogue and timbru31 May 21, 2020
package.json Outdated Show resolved Hide resolved
@erisu erisu requested a review from dpogue May 21, 2020
@erisu erisu changed the title chore: add cordova-ios requirement <=5.1.1 chore: add cordova-ios requirement <6.0.0 May 21, 2020
dpogue
dpogue approved these changes May 21, 2020
@erisu erisu merged commit ed1db66 into apache:master Jun 1, 2020
2 checks passed
@erisu erisu deleted the chore/add-ios-requirement branch Jun 1, 2020
@OmarASelim OmarASelim mentioned this pull request Jul 6, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants