Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove ios platform code from plugin repo #263

Merged
merged 4 commits into from Jun 26, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 21, 2020

Platforms affected

ios

Motivation and Context

  • SplashScreen plugin is no longer needed for Cordova iOS 6.x. The plugin code has been integrated.

  • Cordova iOS 6.x will only support the Launch Storyboard. The README.md will retain iOS related docs so that the all SplashScreen docs on cordova.io will continue to be grouped.

Description

  • remove all ios code
  • remove ios from tests
  • update SplashScreen docs to only talk about iOS Launch Storyboard

Checklist

  • I've updated the documentation if necessary

Copy link
Member

@jcesarmobile jcesarmobile left a comment

looks good

Copy link
Member

@jcesarmobile jcesarmobile left a comment

just a minor comment on the engines

@@ -36,9 +34,6 @@
"cordova-android": ">=3.6.0",
"cordova-windows": ">=4.4.0"
},
"<6.0.0": {
"cordova-ios": "<6.0.0"
},
"6.0.0": {
Copy link
Member

@jcesarmobile jcesarmobile Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be bumped to 7 or it won't install

Suggested change
"6.0.0": {
"7.0.0": {

Copy link
Member Author

@erisu erisu Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that change in a separate PR.

@NiklasMerz
Copy link
Member

NiklasMerz commented Jun 25, 2020

Why has this PR no Travis Run? Is the travis.yml broken or am I missing something?

@NiklasMerz
Copy link
Member

NiklasMerz commented Jun 25, 2020

No sorry Github is broken. Travis has a build.

@erisu erisu requested a review from jcesarmobile Jun 25, 2020
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Code and quick test LGTM 👍

@erisu erisu merged commit d85e440 into apache:master Jun 26, 2020
2 checks passed
@erisu erisu deleted the breaking/drop-ios branch Jun 26, 2020
@zeshanb
Copy link

zeshanb commented Oct 24, 2021

I am also having iOS "Launch Screen" issues.

The Images are suppose to appear in this directory:
images-need-placed-here

The Images.xcassets directory is located under resources iOS Xcode project:
under-resources-xcode-project

Bare minimum only the following images were required:

The Xcode interface generates a .json file and the .json file is placed in LaunchStoryboard.imageset directory. Only few images are required. Here is a sample of the json file:

{
  "images" : [
    {
      "filename" : "default-2.png",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "filename" : "default-568h@2x-1.png",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "filename" : "default-portrait-736h@3x-1.png",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "filename" : "default-3.png",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "filename" : "default@2x-1.png",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    }
  ],
  "info" : {
    "author" : "xcode",
    "version" : 1
  }
}

I would appreciate if this issue can be resolved at your convenience. Thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants