breaking: remove ios platform code from plugin repo by erisu · Pull Request #263 · apache/cordova-plugin-splashscreen

erisu · 2020-05-21T07:47:44Z

Platforms affected

ios

Motivation and Context

SplashScreen plugin is no longer needed for Cordova iOS 6.x. The plugin code has been integrated.
Cordova iOS 6.x will only support the Launch Storyboard. The README.md will retain iOS related docs so that the all SplashScreen docs on cordova.io will continue to be grouped.

Description

remove all ios code
remove ios from tests
update SplashScreen docs to only talk about iOS Launch Storyboard

Checklist

I've updated the documentation if necessary

jcesarmobile

looks good

jcesarmobile

just a minor comment on the engines

jcesarmobile · 2020-06-25T14:32:06Z

-      "<6.0.0": {
-        "cordova-ios": "<6.0.0"
-      },
      "6.0.0": {


this should be bumped to 7 or it won't install

Suggested change

"6.0.0": {

"7.0.0": {

I will do that change in a separate PR.

NiklasMerz · 2020-06-25T17:11:18Z

Why has this PR no Travis Run? Is the travis.yml broken or am I missing something?

NiklasMerz · 2020-06-25T17:12:17Z

No sorry Github is broken. Travis has a build.

NiklasMerz

Code and quick test LGTM 👍

zeshanb · 2021-10-24T20:56:45Z

I am also having iOS "Launch Screen" issues.

The Images are suppose to appear in this directory:

The Images.xcassets directory is located under resources iOS Xcode project:

Bare minimum only the following images were required:

default-2.png at 320 x 480 pixels
default-568h@2x-1.png at 640 x 1136
default-portrait-736h@3x-1.png at 1242 x 2208
default@2x-1.png at 640x960

The Xcode interface generates a .json file and the .json file is placed in LaunchStoryboard.imageset directory. Only few images are required. Here is a sample of the json file:

{
  "images" : [
    {
      "filename" : "default-2.png",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "filename" : "default-568h@2x-1.png",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "filename" : "default-portrait-736h@3x-1.png",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "filename" : "default-3.png",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "filename" : "default@2x-1.png",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    }
  ],
  "info" : {
    "author" : "xcode",
    "version" : 1
  }
}

I would appreciate if this issue can be resolved at your convenience. Thank you for your time.

…)"

…pache#263)"" This reverts commit 5f27002.

erisu added the enhancement label May 21, 2020

erisu added this to the 6.0.0 milestone May 21, 2020

erisu requested review from dpogue and timbru31 May 21, 2020 07:47

timbru31 mentioned this pull request May 23, 2020

Remove Legacy launch method, not support anymore #254

Closed

5 tasks

antikalk mentioned this pull request Jun 5, 2020

(iOS) cordova-ios@6.0.0 - unable to click anything in the app after the splashscreen is hidden #268

Closed

3 tasks

erisu force-pushed the breaking/drop-ios branch 2 times, most recently from b4358aa to 89321ed Compare June 25, 2020 04:35

erisu requested a review from NiklasMerz June 25, 2020 06:17

This was referenced Jun 25, 2020

breaking: bump version 6.0.0-dev #262

Merged

fix: upgrade test's xcode project #266

Closed

jcesarmobile self-requested a review June 25, 2020 13:37

jcesarmobile approved these changes Jun 25, 2020

View reviewed changes

erisu added 3 commits June 25, 2020 23:26

chore: add cordova-ios requirement <=5.1.1

10336d8

breaking: remove ios platform code from plugin repo

fe70384

chore: update README.md, remove iOS legacy splashscreen information

49d5bd9

erisu force-pushed the breaking/drop-ios branch from 89321ed to 40a0c3c Compare June 25, 2020 14:26

jcesarmobile requested changes Jun 25, 2020

View reviewed changes

chore: simplifiy local browser tests

a7e9f2e

erisu force-pushed the breaking/drop-ios branch from 40a0c3c to a7e9f2e Compare June 25, 2020 17:12

erisu requested a review from jcesarmobile June 25, 2020 17:14

NiklasMerz approved these changes Jun 25, 2020

View reviewed changes

jcesarmobile approved these changes Jun 25, 2020

View reviewed changes

erisu merged commit d85e440 into apache:master Jun 26, 2020

erisu deleted the breaking/drop-ios branch June 26, 2020 02:57

faugusztin mentioned this pull request Oct 17, 2020

Why is there no IOS platform #299

Closed

vogloblinsky mentioned this pull request May 18, 2021

iOS splash screen loader not showing #308

Closed

3 tasks

zeshanb mentioned this pull request Oct 24, 2021

iOS Launch screen images do not display in emulator and required to be copied to a Xcode project folder #321

Closed

fredriksthlm mentioned this pull request Jan 14, 2022

Splashscreen automatically added - causes tedious work to remove everytime Scirra/Construct-bugs#5372

Closed

msowahexagon added a commit to HexagonGeospatial/cordova-plugin-splashscreen-hx that referenced this pull request Sep 8, 2023

Revert "breaking: remove ios platform code from plugin repo (apache#263…

5f27002

…)"

paulinazakrzewska pushed a commit to HexagonGeospatial/cordova-plugin-splashscreen-hx that referenced this pull request Sep 14, 2023

Revert "Revert "breaking: remove ios platform code from plugin repo (a…

50392cd

…pache#263)"" This reverts commit 5f27002.

Navigation Menu

Uh oh!

breaking: remove ios platform code from plugin repo - #263

breaking: remove ios platform code from plugin repo#263
erisu merged 4 commits into
apache:masterfrom
erisu:breaking/drop-ios

erisu commented May 21, 2020

Uh oh!

jcesarmobile left a comment

Uh oh!

jcesarmobile left a comment

Uh oh!

jcesarmobile Jun 25, 2020

Uh oh!

erisu Jun 25, 2020

Uh oh!

NiklasMerz commented Jun 25, 2020

Uh oh!

NiklasMerz commented Jun 25, 2020

Uh oh!

NiklasMerz left a comment

Uh oh!

zeshanb commented Oct 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

erisu commented May 21, 2020

Platforms affected

Motivation and Context

Description

Checklist

Uh oh!

jcesarmobile left a comment

Choose a reason for hiding this comment

Uh oh!

jcesarmobile left a comment

Choose a reason for hiding this comment

Uh oh!

jcesarmobile Jun 25, 2020

Choose a reason for hiding this comment

Uh oh!

erisu Jun 25, 2020

Choose a reason for hiding this comment

Uh oh!

NiklasMerz commented Jun 25, 2020

Uh oh!

NiklasMerz commented Jun 25, 2020

Uh oh!

NiklasMerz left a comment

Choose a reason for hiding this comment

Uh oh!

zeshanb commented Oct 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants