Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: remove ios platform code from plugin repo #263

Merged
merged 4 commits into from
Jun 26, 2020
Merged

breaking: remove ios platform code from plugin repo #263

merged 4 commits into from
Jun 26, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 21, 2020

Platforms affected

ios

Motivation and Context

  • SplashScreen plugin is no longer needed for Cordova iOS 6.x. The plugin code has been integrated.

  • Cordova iOS 6.x will only support the Launch Storyboard. The README.md will retain iOS related docs so that the all SplashScreen docs on cordova.io will continue to be grouped.

Description

  • remove all ios code
  • remove ios from tests
  • update SplashScreen docs to only talk about iOS Launch Storyboard

Checklist

  • I've updated the documentation if necessary

@erisu erisu added this to the 6.0.0 milestone May 21, 2020
@erisu erisu requested review from dpogue and timbru31 May 21, 2020 07:47
@timbru31 timbru31 mentioned this pull request May 23, 2020
Closed
5 tasks
@antikalk antikalk mentioned this pull request Jun 5, 2020
Closed
3 tasks
@erisu erisu force-pushed the breaking/drop-ios branch 2 times, most recently from b4358aa to 89321ed Compare June 25, 2020 04:35
@erisu erisu requested a review from NiklasMerz June 25, 2020 06:17
This was referenced Jun 25, 2020
Merged
Closed
@jcesarmobile jcesarmobile self-requested a review June 25, 2020 13:37
jcesarmobile
jcesarmobile approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@erisu erisu force-pushed the breaking/drop-ios branch from 89321ed to 40a0c3c Compare June 25, 2020 14:26
jcesarmobile
jcesarmobile requested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment on the engines

package.json
@@ -36,9 +34,6 @@
"cordova-android": ">=3.6.0",
"cordova-windows": ">=4.4.0"
},
"<6.0.0": {
"cordova-ios": "<6.0.0"
},
"6.0.0": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be bumped to 7 or it won't install

Suggested change
"6.0.0": {
"7.0.0": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that change in a separate PR.

@NiklasMerz
Copy link
Member

Why has this PR no Travis Run? Is the travis.yml broken or am I missing something?

@erisu erisu force-pushed the breaking/drop-ios branch from 40a0c3c to a7e9f2e Compare June 25, 2020 17:12
@NiklasMerz
Copy link
Member

No sorry Github is broken. Travis has a build.

@erisu erisu requested a review from jcesarmobile June 25, 2020 17:14
NiklasMerz
NiklasMerz approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and quick test LGTM 👍

@erisu erisu merged commit d85e440 into apache:master Jun 26, 2020
@erisu erisu deleted the breaking/drop-ios branch June 26, 2020 02:57
@faugusztin faugusztin mentioned this pull request Oct 17, 2020
Closed
@vogloblinsky vogloblinsky mentioned this pull request May 18, 2021
Closed
3 tasks
@zeshanb
Copy link

zeshanb commented Oct 24, 2021

I am also having iOS "Launch Screen" issues.

The Images are suppose to appear in this directory:
images-need-placed-here

The Images.xcassets directory is located under resources iOS Xcode project:
under-resources-xcode-project

Bare minimum only the following images were required:

The Xcode interface generates a .json file and the .json file is placed in LaunchStoryboard.imageset directory. Only few images are required. Here is a sample of the json file:

{
  "images" : [
    {
      "filename" : "default-2.png",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "filename" : "default-568h@2x-1.png",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "filename" : "default-portrait-736h@3x-1.png",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x"
    },
    {
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "universal",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x"
    },
    {
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "iphone",
      "scale" : "3x",
      "width-class" : "compact"
    },
    {
      "filename" : "default-3.png",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "filename" : "default@2x-1.png",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x"
    },
    {
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "1x",
      "width-class" : "compact"
    },
    {
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "light"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    },
    {
      "appearances" : [
        {
          "appearance" : "luminosity",
          "value" : "dark"
        }
      ],
      "height-class" : "compact",
      "idiom" : "ipad",
      "scale" : "2x",
      "width-class" : "compact"
    }
  ],
  "info" : {
    "author" : "xcode",
    "version" : 1
  }
}

I would appreciate if this issue can be resolved at your convenience. Thank you for your time.

@zeshanb zeshanb mentioned this pull request Oct 24, 2021
Closed
@fredriksthlm fredriksthlm mentioned this pull request Jan 14, 2022
Closed
msowahexagon added a commit to HexagonGeospatial/cordova-plugin-splashscreen-hx that referenced this pull request Sep 8, 2023
@msowahexagon
Revert "breaking: remove ios platform code from plugin repo (apache#263…
5f27002 
…)"
paulinazakrzewska pushed a commit to HexagonGeospatial/cordova-plugin-splashscreen-hx that referenced this pull request Sep 14, 2023
Revert "Revert "breaking: remove ios platform code from plugin repo (a…
50392cd 
…pache#263)""

This reverts commit 5f27002.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erisu @NiklasMerz @zeshanb @jcesarmobile