fix: js clobber only on supported platforms#282
Merged
erisu merged 1 commit intoJul 7, 2020
Conversation
timbru31
approved these changes
Jul 6, 2020
jcesarmobile
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
all
Motivation and Context
The shared JS content is being clobbered on all platforms even if the platform is not supported.
iOS is affected by this clobber because it has its own JS file that is clobbered on the same
window.navigatorscope.Description
Move the shared JS clobber into each defined platform until a better solution is implemented to be more strict on plugin installs.
Testing
Checklist