Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: js clobber only on supported platforms #282

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 6, 2020

Platforms affected

all

Motivation and Context

The shared JS content is being clobbered on all platforms even if the platform is not supported.

iOS is affected by this clobber because it has its own JS file that is clobbered on the same window.navigator scope.

Description

Move the shared JS clobber into each defined platform until a better solution is implemented to be more strict on plugin installs.

Testing

  • plugin install & simulator run
    • With mobile spec
    • Without mobile spec
    • With changes
    • With out changes

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Jul 6, 2020
@erisu erisu requested review from dpogue and jcesarmobile Jul 6, 2020
@erisu erisu merged commit faa8aa9 into apache:master Jul 7, 2020
2 checks passed
@erisu erisu deleted the fix/js-clobber-only-on-supported-platforms branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants