Skip to content

fix: refocus after webview visible (#186) - #314

Merged
erisu merged 1 commit into
apache:masterfrom
knight9999:dev-issue-186-backbtn
Jul 28, 2021
Merged

erisu merged 1 commit into
apache:masterfrom
knight9999:dev-issue-186-backbtn

Conversation

@knight9999

@knight9999 knight9999 commented Jul 22, 2021 •

Copy link
Copy Markdown
Contributor

Platforms affected

android

Motivation and Context

After Android SDK 28, the android buck-button key event can not be handled.
This issue happens because the webview gets out of focus.
This PR made the webview to refocus after url loading.

fixes: #186

Description

Testing

In my local environment I tested by creating sample app with cordova-android 9.1.0 and cordova 10.0.0.
I also run npm run test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu
erisu merged commit 66d1e00 into apache:master Jul 28, 2021
@5r1m

5r1m commented Oct 19, 2021

Copy link
Copy Markdown

@erisu, can you please share when the next release would be? This issue has been pending for a very long time. Thanks.

@nvkhanh

nvkhanh commented Nov 30, 2021

Copy link
Copy Markdown

@erisu I have the same issue with my android device (API 30)

can you release the new version for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android 9 - target SDK 28] Backbutton not working

4 participants