Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: replace dependency opn w/ open #30

Merged
merged 1 commit into from Apr 1, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 1, 2020

Motivation and Context

  • Remove npm warning

npm WARN deprecated opn@6.0.0: The package has been renamed to open

Description

  • Drop opn dependency
  • Add open dependency
  • Rebuilt package-lock.json

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Apr 1, 2020
@erisu erisu requested a review from timbru31 Apr 1, 2020
@codecov-io
Copy link

@codecov-io codecov-io commented Apr 1, 2020

Codecov Report

Merging #30 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   27.98%   27.98%           
=======================================
  Files           6        6           
  Lines         218      218           
=======================================
  Hits           61       61           
  Misses        157      157           
Impacted Files Coverage Δ
src/browser.js 18.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8ec0d...7377cf3. Read the comment docs.

@erisu erisu merged commit 8a44682 into apache:master Apr 1, 2020
6 checks passed
@erisu erisu deleted the breaking/swap-opn-to-open-dependency branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants