Any problem in build process triggers "No valid MSBuild was detected for the selected target:" exception

[janpio]

After code restructuring this Exception is triggered a bit too often.

E.g. if just the build process in MSBuild fails:

CordovaError: No valid MSBuild was detected for the selected target: Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with exit code 1

This issue refers to a problem in the way the code is structured - returning an exception that is not 100% correct all the times.

[shazron]

Essentially the MSBuild detection code does not work well with VS 2017. Duping this into #274

[janpio]

The original issue was another problem - any problem in the build process triggers this error message as it is a general catch for any error.

[janpio]

For future reference, this is the offending code:

cordova-windows/template/cordova/lib/build.js

Lines 63 to 85 in c52b81c

	return MSBuildTools.getLatestMatchingMSBuild(selectedBuildTargets) // get latest msbuild tools
	.then(function (result) {
	var msbuild = result[0];
	var myBuildTargets = result[1];
	// Apply build related configs
	prepare.updateBuildConfig(buildConfig);
	if (buildConfig.publisherId) {
	updateManifestWithPublisher(buildConfig, myBuildTargets);
	}
	cleanIntermediates();
	// build!
	return buildTargets(buildConfig, myBuildTargets, msbuild);
	}).then(function (pkg) {
	events.emit('verbose', ' BUILD OUTPUT: ' + pkg.appx);
	return pkg;
	}).catch(function (error) {
	return Q.reject(new CordovaError('No valid MSBuild was detected for the selected target: ' + error, error));
	});
	};