New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13875 add `prepare` script that can be called in e2e tests #254

Merged
merged 4 commits into from Feb 14, 2018

Conversation

Projects
None yet
1 participant
@janpio
Contributor

janpio commented Feb 13, 2018

… to prepare project files

(based on clean and some terrible code to build a project object)
also adds default config.xml as in other projects

replaces #250

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.
CB-13875 add `prepare` script that can be called in e2e tests to prep…
…are project files

(based on `clean` and some terrible code to build a `project` object)
also adds default `config.xml`
require('./lib/loggingHelper').adjustLoggerLevel(opts);
var projectRoot = path.join(__dirname, '..');
var project = {

This comment has been minimized.

@janpio

janpio Feb 13, 2018

Contributor

this is pretty ugly here, but prepare is the only one of the "main" commands that takes a project as a param so I had to improvise. think the end result isn't that bad.

@janpio janpio referenced this pull request Feb 13, 2018

Closed

[CB-13861] Update TargetPlatformVersion #250

3 of 3 tasks complete

@janpio janpio requested a review from purplecabbage Feb 13, 2018

@janpio

This comment has been minimized.

Contributor

janpio commented Feb 13, 2018

The missing index.html in the test project is causing issues now:

EXEC : warning : Start page is missing on the disk. The build must go on but note that this will cause WACK failures. [C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
MakeAppx : error : Manifest validation error: Line 26, Column 47, Reason: The file name "www\index.html" declared for element "m:Applications/m:Application" doesn't exist in the package. [C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
MakeAppx : error : Package creation failed. [C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
MakeAppx : error : 0x80080204 - The specified package format is not valid: The package manifest is not valid. 

Locally I only get the first line, but on CI the MSBuildTools version seems to do some additional validation.

Working on a fix.

janpio added some commits Feb 13, 2018

@janpio

This comment has been minimized.

Contributor

janpio commented Feb 13, 2018

Fixed by making sure the index.html is present (by copying from a folder where it exists).

This is now as good as master but works with any Windows 10 SDK installed.

@janpio janpio changed the title from [WIP] CB-13875 add `prepare` script that can be called in e2e tests to CB-13875 add `prepare` script that can be called in e2e tests Feb 13, 2018

@janpio janpio merged commit 20ed375 into master Feb 14, 2018

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@janpio janpio deleted the janpio-prepare_script_in_e2e branch Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment