Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make couchjs -S option take effect #216
Previously it was used to set JS context's stack chunk size.
Instead, to be effective it should set max GC size of the runtime.
Stack chunk size was set to the recommended value: 8K
Though it's curious how the previous fix https://issues.apache.org/jira/browse/COUCHDB-1792 was apparently never applied. However, it clearly seems to be the right thing to do.
I think the fix was applied then switched back during a refactoring?
It is interesting why it works though. I think it probably masking a fundamental and tricky bug with garbage collection. By essentially stopping it from running.
However for practical reasons we saw that at least this brings us back to behavior that we've had before in production.
Previously it was used to set JS context's stack chunk size. Instead, to be effective it should set max GC size of the runtime. Stack chunk size was set to the recommended value: 8K This brings back an accidentally reverted commit: 62dafe8 by @tilgovi Reference: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_NewContext COUCHDB-3245