Fix badmatch in fabric_view_all_docs #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In query for all_docs with passed keys array it is possible for `doc_receive_loop/6` to timeout and trigger `badmatch` exception. The fix changes code to to accept `timeout` as a possible response and passes it to Callback to process.
wohali
approved these changes
Aug 28, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In query for
all_docswith passedkeysarray it is possible fordoc_receive_loop/6to timeout and triggerbadmatchexception.The fix changes code to accept
timeoutas a possible response and passes it to Callback to process.Testing recommendations
It's kind of hard to induce timeout on that all_docs read without actual code tweaking, so base tests just need to pass.
Related Issues or Pull Requests
Described in #2149
Checklist
rel/overlay/etc/default.ini