Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VM_ARGS with ARGS_FILE which is borrowed from couchdb startup #2738

Merged
merged 3 commits into from Apr 22, 2020

Conversation

sklassen
Copy link
Contributor

Replaced the environment VM_ARGS with ARGS_FILE, which is the same name and set the same manner as the couchdb script;

The new script also parses name from the same file.

Overview

The current remsh script required you specify the name and cookie if they differ from the system default. The new script synchronizes the setting of ARGS_FILE with that environment in the couchdb startup script. This now also, like the couchdb startup script, respects any COUCHDB_ARGS_FILE override.

Testing recommendations

I changed the COUCHDB_ARGS_FILE environment variable and reran rmsh it and saw that it picked up non-default name and cookie.

Related Issues or Pull Requests

This answers (the linux) part of #2176

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@wohali wohali merged commit 440ab26 into apache:master Apr 22, 2020
wohali added a commit that referenced this pull request Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738)

Co-authored-by: sklassen <none>
Co-authored-by: Joan Touzet <wohali@users.noreply.github.com>
wohali added a commit that referenced this pull request Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738)

Co-authored-by: sklassen <none>
Co-authored-by: Joan Touzet <wohali@users.noreply.github.com>
wohali added a commit that referenced this pull request Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) (#2809)

Co-authored-by: Joan Touzet <wohali@users.noreply.github.com>
Co-authored-by: Simon Klassen <6997477+sklassen@users.noreply.github.com>
wohali added a commit that referenced this pull request Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) (#2810)

Co-authored-by: Joan Touzet <wohali@users.noreply.github.com>
Co-authored-by: Simon Klassen <6997477+sklassen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants