Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SpiderMonkey 68 #2770

Closed
wohali opened this issue Apr 9, 2020 · 3 comments · Fixed by #2788
Closed

Support SpiderMonkey 68 #2770

wohali opened this issue Apr 9, 2020 · 3 comments · Fixed by #2788
Assignees

Comments

@wohali
Copy link
Member

@wohali wohali commented Apr 9, 2020

Summary

Ubuntu focal (20.04) comes out in 2 weeks. That distribution no longer carries libmozjs-60, substituting libmozjs-68 instead. This will also be the case for Debian bullseye (11.0).

Unless we want to go back to shipping our own SM packages, our best option is to carry forward support to SM68.

Possible Solution

I've started work on this locally and will push a PR once it's ready. There's significant enough changes that it's not just a rebar.config.script tweak, unfortunately.

@wohali wohali self-assigned this Apr 9, 2020
@wohali wohali mentioned this issue Apr 15, 2020
3 tasks
@florianb
Copy link

@florianb florianb commented Apr 15, 2020

@wohali i missed the version of the actual js-engine when invoking couchjs -V, it might be a quick enhancement adding JS_GetImplementationVersion to the version output.

@wohali
Copy link
Member Author

@wohali wohali commented Apr 15, 2020

@florianb If you would like to add this (preferably, after the UTF8 and SM68 PRs land) it'd be a welcome addition.

Remember that SM 1.8.5 may not have this, so it'll need manual testing. Our usual CI builds won't pick this up. If you pull our couchdbdev/debian-stretch-erlang-20.3.8.25-1 image, that still contains 1.8.5.

@florianb
Copy link

@florianb florianb commented Apr 16, 2020

Aye - ✔️ SM 1.8.5 supports it: https://github.com/florianb/mozjs185/blob/f07f5186515453bcf8a161e021f091d95f262665/js/src/jsapi.cpp#L1141

I'll subscribe the PR - hopefully i'll recognize its landing. otherwise bump me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants