Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support sm91 3.x from lostnet #3883

Conversation

lostnet
Copy link
Contributor

@lostnet lostnet commented Dec 23, 2021

Overview

Supporting changes necessary to build/test spidermonkey 91esr on windows and linux/arm64 for the 3.x.

Testing recommendations

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

@lostnet lostnet mentioned this pull request Jan 5, 2022
4 tasks
@janl
Copy link
Member

janl commented Mar 12, 2022

@lostnet nice work here. Isn’t his missing an entry here?

https://github.com/apache/couchdb/blob/3.x/src/couch/rebar.config.script#L66-L67

1 similar comment
@janl
Copy link
Member

janl commented Mar 12, 2022

@lostnet nice work here. Isn’t his missing an entry here?

https://github.com/apache/couchdb/blob/3.x/src/couch/rebar.config.script#L66-L67

@lostnet
Copy link
Contributor Author

lostnet commented Mar 12, 2022

Hi @janl, that looks like 3.x, but this pull is based on the feat/support-sm91-3.x-from-lostnet branch since your backport from 4.x of the original changes looks good to me:
https://github.com/apache/couchdb/blob/feat/support-sm91-3.x-from-lostnet/src/couch/rebar.config.script#L68

@janl
Copy link
Member

janl commented Mar 12, 2022

oh I’m now realising this is a PR to a feature branch and not 3.x, never mind! :D

@janl janl merged commit 2996afc into apache:feat/support-sm91-3.x-from-lostnet Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants