Fix query args parsing during cluster upgrades #5596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit caa4f9b we optimized query args validation so it happens on the coordinator side only. However, during online cluster upgrades some requests like _all_docs from old nodes executed on newly upgrades nodes will fail as the args won't be validated. To bridge the online upgrade gap add a `validated` optional flag to args. If the flag is not set, the workers will validate the args; if the flag is already set by the coordinator, they won't be revalidated, so we don't lose the minor performance gain from having to validate them twice.
jiahuili430
approved these changes
Jul 9, 2025
Contributor
jiahuili430
left a comment
jiahuili430
left a comment
There was a problem hiding this comment.
Thank you for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit caa4f9b we optimized query args validation so it happens on the coordinator side only. However, during online cluster upgrades some requests like _all_docs from old nodes executed on newly upgrades nodes will fail as the args won't be validated.
To bridge the online upgrade gap add a
validatedoptional flag to args. If the flag is not set, the workers will validate the args; if the flag is already set by the coordinator, they won't be revalidated, so we don't lose the minor performance gain from having to validate them twice.