nouveau: use http/2 #5598
nouveau: use http/2 #5598
Conversation
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
61c03f9 to
92bd607
Compare
|
had to eliminate the 204 responses due to ninenines/cowlib#140 so instead of no resp body I send |
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
92bd607 to
8284c7c
Compare
|
should address the issue in #5597 also. with http/2 each couchdb node has one tcp connection to the nouveau server and multiplexes index update and search requests in it. |
rnewson
force-pushed
the
nouveau-gun-http2
branch
3 times, most recently
from
37883dc to
d58ea64
Compare
rebar.config.script
Outdated
| {fauxton, {url, "https://github.com/apache/couchdb-fauxton"}, | ||
| {tag, "v1.3.4"}, [raw]}, | ||
| {ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-6"}}, | ||
| {gun, {url, "https://github.com/ninenines/gun"}, |
There was a problem hiding this comment.
We'd probably want to mirror the dependency I think those are the ASF rules. For some repos like proper we don't do it because they are not part of the final release.
nickva
left a comment
nickva
left a comment
There was a problem hiding this comment.
+1 if CI passes
This is quite nice. Maybe if gun gets it's foot in the door this way we can start using for the replicator. I saw the author started work on http/3 even.
Just see a note about maybe having to mirror repo in apache org.
rnewson
force-pushed
the
nouveau-gun-http2
branch
2 times, most recently
from
273a353 to
0c7f7e5
Compare
There was a problem hiding this comment.
Don’t forget to update configure.ps1 too.
There was a problem hiding this comment.
done but no way to validate
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
0c7f7e5 to
cc98567
Compare
we lose the pipelining benefit for indexing as http/2 does not support it but we benefit from far fewer connections between couchdb and nouveau server.
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
cc98567 to
2578b55
Compare
3 participants
we lose the pipelining benefit for indexing as http/2 does not support it (and we need the requests that update the index to happen in the order we issue them).