Improve scanner performance #5613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the plugin doesn't need to inspect ddocs at the cluster level, avoid the
expensive `fabric:all_docs()` call, both the finder and the conflict checker
benefit from this one.
* Let the plugins examine the `#full_doc_info{}` structure directly in the new
optional `doc_fdi` callback. Previously, the conflict checker had to re-read
the FDI just to look for conflict even though the plugin already read the FDI.
jiahuili430
approved these changes
Aug 1, 2025
Contributor
jiahuili430
left a comment
jiahuili430
left a comment
There was a problem hiding this comment.
+1
Tested locally and it works as expected.
Thank you for improving the performance for the scanner!
Contributor
Author
|
@jiahuili430 thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin doesn't need to inspect ddocs at the cluster level, avoid the expensive
fabric:all_docs()call, both the finder and the conflict checker benefit from this one.Let the plugins examine the
#full_doc_info{}structure directly in the new optionaldoc_fdicallback. Previously, the conflict checker had to re-read the FDI just to look for conflict even though the plugin already read the FDI.