[WIP] Re-introduce etags in view #1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiri
force-pushed
the
reintroduce-view-etag
branch
3 times, most recently
from
abab24c
to
58904dd
Compare
eiri
changed the title
eiri
force-pushed
the
reintroduce-view-etag
branch
from
58904dd
to
19440d8
Compare
|
Will it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Work In Progress, not ready for review yet.
Overview
We had to remove
ETagheader from views in clustered env. Reportedly this had a noticeable effect on performance, so this PR is making an attempt to bring reliable etags back.Testing recommendations
For now the standard test suite should continue to pass.
Related Issues or Pull Requests
Checklist