Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error when changes forced to rewind to beginning #1568

Merged
merged 1 commit into from Sep 5, 2018

Conversation

@jaydoane
Copy link
Contributor

@jaydoane jaydoane commented Aug 20, 2018

Overview

During a recent rolling upgrade, we observed the changes feed rewinding to a very old version, which caused performance issues for the client since it had to slog through millions of previously seen changes. Unfortunately, there is no logging when the changes endpoint is forced to rewind, so this adds such logging .

Testing recommendations

Unfortunately, this is not trivial to test.

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
@jaydoane jaydoane force-pushed the cloudant:log-changes-rewind-reasons branch from ce27764 to 46e1bb8 Aug 28, 2018
@jaydoane jaydoane force-pushed the cloudant:log-changes-rewind-reasons branch from 46e1bb8 to 64e4282 Aug 29, 2018
@jaydoane
Copy link
Contributor Author

@jaydoane jaydoane commented Aug 29, 2018

I've squashed into a single commit. @rnewson do you mind merging this?

@jaydoane jaydoane force-pushed the cloudant:log-changes-rewind-reasons branch from 64e4282 to 15086c3 Sep 4, 2018
@jaydoane jaydoane force-pushed the cloudant:log-changes-rewind-reasons branch from 15086c3 to 1a75eec Sep 5, 2018
@jiangphcn jiangphcn merged commit 485e9ca into apache:master Sep 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jaydoane jaydoane deleted the cloudant:log-changes-rewind-reasons branch Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants