Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of database creation parameters #1582

Merged
merged 1 commit into from Aug 27, 2018

Conversation

@rnewson
Copy link
Member

@rnewson rnewson commented Aug 27, 2018

Overview

Improves validation of database creation parameters, giving a more readable error.

Testing recommendations

Try to create a db with invalid parameters and confirm a clean error response (and no database)

Related Issues or Pull Requests

N/A

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
@janl
Copy link
Member

@janl janl commented Aug 27, 2018

+1

@janl janl closed this Aug 27, 2018
@janl janl reopened this Aug 27, 2018
@davisp
Copy link
Member

@davisp davisp commented Aug 27, 2018

+1

@rnewson rnewson merged commit fc92fbe into master Aug 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rnewson rnewson deleted the improve-dbcreate-validation branch Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants