Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid restarting /_replicate jobs if parameters haven't changed #1635

Merged

Conversation

@nickva
Copy link
Contributor

@nickva nickva commented Oct 2, 2018

This used to be the case before the scheduling replicator:

https://github.com/apache/couchdb-couch-replicator/blob/master/src/couch_replicator.erl#L166

This is also how replications backed by a document in a _replicator db behave:

https://github.com/apache/couchdb/blob/master/src/couch_replicator/src/couch_replicator_doc_processor.erl#L283

@iilyak
iilyak approved these changes Oct 2, 2018
Copy link
Contributor

@iilyak iilyak left a comment

Good find.

@nickva nickva force-pushed the cloudant:do-no-restart-replications-if-not-needed branch from 424a35a to 6c6c86b Oct 2, 2018
@nickva nickva merged commit 080da7c into apache:master Oct 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nickva nickva deleted the cloudant:do-no-restart-replications-if-not-needed branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants