New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial view compaction task status #1672

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@davisp
Member

davisp commented Oct 22, 2018

This is a minor consistency issue. Currently when a view compaction
starts it doesn't include the total_changes and changes_done fields
until the first task status update. This is easy to miss as every other
task type includes those fields from the initial task definition.

The obvious trivial fix is both obvious and trivial.

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
Fix initial view compaction task status
This is a minor consistency issue. Currently when a view compaction
starts it doesn't include the `total_changes` and `changes_done` fields
until the first task status update. This is easy to miss as every other
task type includes those fields from the initial task definition.

The obvious trivial fix is both obvious and trivial.
@nickva

nickva approved these changes Oct 22, 2018

+1

@wohali wohali merged commit 096994b into master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wohali wohali deleted the fix-view-compactor-task-status branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment